Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3879] Logger of slf4j does not work in eventmesh-common test module #3882

Closed
wants to merge 3 commits into from

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented May 7, 2023

Fixes #3879.

Motivation

The object of org.slf4j.Logger can not execute no matter log.info, log.error and so on in test.

Modifications

Add log4j2.xml to eventmesh-common test module

Documentation

  • Does this pull request introduce a new feature? no

@pandaapo pandaapo changed the title [ISSUE #3879]Logger of slf4j does not work in eventmesh-common module [ISSUE #3879]Logger of slf4j does not work in eventmesh-common test module May 8, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3882 (7dcee91) into master (0ce8d57) will decrease coverage by 0.30%.
The diff coverage is n/a.

❗ Current head 7dcee91 differs from pull request most recent head 577dd90. Consider uploading reports for the commit 577dd90 to get more accurate results

@@             Coverage Diff              @@
##             master    #3882      +/-   ##
============================================
- Coverage     14.24%   13.94%   -0.30%     
+ Complexity     1320     1291      -29     
============================================
  Files           579      570       -9     
  Lines         28967    28847     -120     
  Branches       2802     2811       +9     
============================================
- Hits           4125     4024     -101     
  Misses        24450    24450              
+ Partials        392      373      -19     

see 145 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia
Copy link
Member

Can we only add a xml configuration file under this module? This PR #4719 proposes an alternative way to manage the Slf4j dependency, and let's looking forward to it.

@pandaapo pandaapo closed this Jan 11, 2024
@Pil0tXia Pil0tXia changed the title [ISSUE #3879]Logger of slf4j does not work in eventmesh-common test module [ISSUE #3879] Logger of slf4j does not work in eventmesh-common test module Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Logger of slf4j does not work in eventmesh-common test module
3 participants