[ISSUE #4052] Implement the functionality of EventMeshVersion class. #4055

pandaapo · 2023-05-31T09:05:30Z

Fixes #4052.

Motivation

Currently, EventMeshVersion.java does not provide any actual functionality. We should complete its work.

We can print version of EventMesh when it starts up.

Modifications

Make EventMeshVersion.java can get current version of EventMesh source code or jar.

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

codecov · 2023-06-05T12:11:58Z

Codecov Report

Merging #4055 (4c28834) into master (ae961bf) will increase coverage by 0.00%.
The diff coverage is 37.80%.

❗ Current head 4c28834 differs from pull request most recent head d5b7abd. Consider uploading reports for the commit d5b7abd to get more accurate results

@@            Coverage Diff            @@
##             master    #4055   +/-   ##
=========================================
  Coverage     14.25%   14.25%           
- Complexity     1320     1331   +11     
=========================================
  Files           579      580    +1     
  Lines         28945    28911   -34     
  Branches       2791     2801   +10     
=========================================
- Hits           4125     4121    -4     
+ Misses        24428    24392   -36     
- Partials        392      398    +6

Impacted Files	Coverage Δ
.../apache/eventmesh/common/config/ConfigService.java	`41.37% <0.00%> (-3.07%)`	⬇️
...rg/apache/eventmesh/common/utils/ReflectUtils.java	`0.00% <0.00%> (ø)`
...e/admin/handler/QueryWebHookConfigByIdHandler.java	`26.66% <0.00%> (ø)`
...ndler/QueryWebHookConfigByManufacturerHandler.java	`28.57% <0.00%> (ø)`
.../protocol/tcp/client/task/MessageTransferTask.java	`0.00% <0.00%> (ø)`
.../org/apache/eventmesh/runtime/util/BannerUtil.java	`88.88% <0.00%> (-2.54%)`	⬇️
...ache/eventmesh/trace/api/AbstractTraceService.java	`0.00% <0.00%> (ø)`
...mesh/trace/api/common/EventMeshTraceConstants.java	`0.00% <ø> (ø)`
...tmesh/trace/pinpoint/common/PinpointConstants.java	`0.00% <ø> (ø)`
...eventmesh/trace/zipkin/common/ZipkinConstants.java	`0.00% <ø> (ø)`
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2024-04-12T18:31:05Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

codecov-commenter · 2024-04-12T18:32:26Z

Codecov Report

Attention: Patch coverage is 39.68254% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 14.25%. Comparing base (378aa75) to head (4c28834).
Report is 65 commits behind head on master.

❗ Current head 4c28834 differs from pull request most recent head 67036d9

Please upload reports for the commit 67036d9 to get more accurate results.

Files	Patch %	Lines
.../eventmesh/runtime/constants/EventMeshVersion.java	40.32%	30 Missing and 7 partials ⚠️
.../org/apache/eventmesh/runtime/util/BannerUtil.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4055      +/-   ##
============================================
- Coverage     17.62%   14.25%   -3.37%     
+ Complexity     1784     1331     -453     
============================================
  Files           805      580     -225     
  Lines         29924    28911    -1013     
  Branches       2580     2801     +221     
============================================
- Hits           5273     4121    -1152     
- Misses        24169    24392     +223     
+ Partials        482      398      -84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pandaapo · 2024-04-13T04:08:31Z

It has been 60 days since the last activity on this pull request.

A question unrelated to the PR content: from which point in time does this bot calculate the 60-day period for PRs and the 90-day period for issues?

Pil0tXia

The steps to get the version number look good to me. Is it possible to add a static block of code so that this class automatically saves the version number at application startup for other classes to get? I would like to write a web endpoint for getting the version number.

Pil0tXia · 2024-04-13T04:13:41Z

from which point in time does this bot calculate the 60/90-day period

From the last activity of a thread.

pandaapo · 2024-04-13T04:33:03Z

from which point in time does this bot calculate the 60/90-day period

From the last activity of a thread.

I mean if the point in time is the last activity for this pr/issue then it won't get the 60/90-day result.

pandaapo · 2024-04-13T04:56:58Z

Is it possible to add a static block of code so that this class automatically saves the version number at application startup for other classes to get?

I'm confused about this requirement. The static code block is executed during class loading, all the classes are not yet finished loading and the application is not yet finished starting, where is the need for the version number calculated at this point?

Pil0tXia · 2024-04-13T05:33:32Z

I mean if the point in time is the last activity for this pr/issue then it won't get the 60/90-day result.

60/90 is a preset text. Since bot is recently enabled, it will actually detect threads >= 60/90 days old.

Pil0tXia

where is the need for the version number calculated at this point?

This avoids the time-consuming version retrieval logic the first time the version number is fetched. However, since the cache is already warmed up in the banner drawing, the version number can also be considered to be saved at startup. Then plz forget about it.

Pil0tXia

plz resolve conflicts~

pandaapo · 2024-04-13T06:48:36Z

I mean if the point in time is the last activity for this pr/issue then it won't get the 60/90-day result.

60/90 is a preset text. Since bot is recently enabled, it will actually detect threads >= 60/90 days old.

So for all PRs/issues that are >= 60/90 days old, how does this bot selectively mark them as 'stale' instead of marking most of them at once?

Pil0tXia · 2024-04-13T07:07:54Z

how does this bot selectively mark them as 'stale' instead of marking most of them at once?

The bot reads 30 threads one day and will skip issues tagged with excluded labels.

pchengma

LGTM.

Pil0tXia · 2024-05-22T09:17:58Z

@pchengma Thank you for reviewing! May you please help review #4867 ?

pchengma · 2024-05-22T11:56:59Z

@Pil0tXia Done.

Pil0tXia · 2024-05-22T15:08:25Z

@pandaapo I didn't find a button to re-run the CI, this PR may need a new commit to trigger the latest workflow.

Pil0tXia · 2024-05-23T11:36:45Z

@pandaapo Really smart.

Implement the functionality of EventMeshVersion.

464a0c8

pandaapo mentioned this pull request May 31, 2023

[Question] What is the usage of EventMeshVersion? #3205

Closed

1 task

Modify modifier

d5b7abd

github-actions bot added the Stale label Apr 12, 2024

Pil0tXia reviewed Apr 13, 2024

View reviewed changes

Pil0tXia previously approved these changes Apr 13, 2024

View reviewed changes

fix conflict

67036d9

pandaapo dismissed Pil0tXia’s stale review via 67036d9 April 13, 2024 06:42

Pil0tXia approved these changes Apr 13, 2024

View reviewed changes

github-actions bot removed the Stale label Apr 13, 2024

This was referenced Apr 14, 2024

[Feature] Add protocol exclusive fields filter for /v2/configuration endpoint #4834

Closed

[ISSUE #4834] Add protocol exclusive fields filter for /v2/configuration endpoint #4835

Merged

Pil0tXia added the ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder) label Apr 14, 2024

pchengma approved these changes May 22, 2024

View reviewed changes

pandaapo closed this May 23, 2024

pandaapo reopened this May 23, 2024

Pil0tXia merged commit 9e4e87f into apache:master May 23, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #4052] Implement the functionality of EventMeshVersion class. #4055

[ISSUE #4052] Implement the functionality of EventMeshVersion class. #4055

pandaapo commented May 31, 2023

codecov bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Apr 12, 2024

codecov-commenter commented Apr 12, 2024 •

edited by codecov bot

Loading

pandaapo commented Apr 13, 2024 •

edited

Loading

Pil0tXia left a comment •

edited

Loading

Pil0tXia commented Apr 13, 2024

pandaapo commented Apr 13, 2024

pandaapo commented Apr 13, 2024

Pil0tXia commented Apr 13, 2024

Pil0tXia left a comment

Pil0tXia left a comment

pandaapo commented Apr 13, 2024

Pil0tXia commented Apr 13, 2024

pchengma left a comment

Pil0tXia commented May 22, 2024

pchengma commented May 22, 2024

Pil0tXia commented May 22, 2024

Pil0tXia commented May 23, 2024

[ISSUE #4052] Implement the functionality of EventMeshVersion class. #4055

[ISSUE #4052] Implement the functionality of EventMeshVersion class. #4055

Conversation

pandaapo commented May 31, 2023

Motivation

Modifications

Documentation

codecov bot commented Jun 5, 2023 • edited Loading

Codecov Report

github-actions bot commented Apr 12, 2024

codecov-commenter commented Apr 12, 2024 • edited by codecov bot Loading

Codecov Report

pandaapo commented Apr 13, 2024 • edited Loading

Pil0tXia left a comment • edited Loading

Choose a reason for hiding this comment

Pil0tXia commented Apr 13, 2024

pandaapo commented Apr 13, 2024

pandaapo commented Apr 13, 2024

Pil0tXia commented Apr 13, 2024

Pil0tXia left a comment

Choose a reason for hiding this comment

Pil0tXia left a comment

Choose a reason for hiding this comment

pandaapo commented Apr 13, 2024

Pil0tXia commented Apr 13, 2024

pchengma left a comment

Choose a reason for hiding this comment

Pil0tXia commented May 22, 2024

pchengma commented May 22, 2024

Pil0tXia commented May 22, 2024

Pil0tXia commented May 23, 2024

codecov bot commented Jun 5, 2023 •

edited

Loading

codecov-commenter commented Apr 12, 2024 •

edited by codecov bot

Loading

pandaapo commented Apr 13, 2024 •

edited

Loading

Pil0tXia left a comment •

edited

Loading