Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4319] C SDK Framework #4323

Merged
merged 4 commits into from
Nov 1, 2023
Merged

[ISSUE #4319] C SDK Framework #4323

merged 4 commits into from
Nov 1, 2023

Conversation

zhurq
Copy link
Contributor

@zhurq zhurq commented Aug 4, 2023

Fixes #4319

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Add dirs and libs.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

qqeasonchen
qqeasonchen previously approved these changes Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4323 (5f1f2fe) into master (fef56a5) will decrease coverage by 0.26%.
Report is 137 commits behind head on master.
The diff coverage is 13.38%.

❗ Current head 5f1f2fe differs from pull request most recent head 3a1c5cc. Consider uploading reports for the commit 3a1c5cc to get more accurate results

@@             Coverage Diff              @@
##             master    #4323      +/-   ##
============================================
- Coverage     16.35%   16.09%   -0.26%     
- Complexity     1362     1550     +188     
============================================
  Files           594      730     +136     
  Lines         25393    28640    +3247     
  Branches       2393     2523     +130     
============================================
+ Hits           4152     4611     +459     
- Misses        20818    23581    +2763     
- Partials        423      448      +25     
Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 75.00% <ø> (ø)
...org/apache/eventmesh/common/ThreadPoolFactory.java 16.66% <ø> (ø)
.../eventmesh/common/config/convert/ConverterMap.java 71.73% <ø> (ø)
...common/config/convert/converter/ListConverter.java 54.16% <ø> (ø)
...mmon/config/convert/converter/ObjectConverter.java 59.77% <ø> (ø)
...entmesh/common/enums/EventMeshDataContentType.java 0.00% <ø> (ø)
...eventmesh/common/exception/EventMeshException.java 0.00% <ø> (ø)
...apache/eventmesh/common/file/WatchFileManager.java 67.64% <100.00%> (+9.31%) ⬆️
.../eventmesh/common/loadbalance/LoadBalanceType.java 80.00% <ø> (ø)
.../common/loadbalance/RandomLoadBalanceSelector.java 66.66% <ø> (ø)
... and 148 more

... and 402 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xwm1992
xwm1992 previously approved these changes Nov 1, 2023
Copy link
Contributor

@lrhkobe lrhkobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrhkobe lrhkobe merged commit 80c7f88 into apache:master Nov 1, 2023
7 checks passed
@zhurq zhurq deleted the feature/c-sdk branch November 6, 2023 08:23
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] C SDK Framework
5 participants