Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4275] Support subscription info management with eventmesh-admin module #4468

Merged
merged 20 commits into from
Oct 6, 2023

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Oct 2, 2023

Fixes #4275.

Motivation

This is a subtask of GLCC Subject #4040.

Design Document: https://docs.qq.com/doc/DSk9NU1JiRlBpSXln

eventmesh-admin module is going to be substituted to be deployed independently. For now, a new module eventmesh-console is added to migrate functions of eventmesh-admin gradually.

The eventmesh-admin-kotlin module used Gradle Kotlin DSL instead of Gradle Groovy DSL to manage dependencies, because Kotlin DSL is the default Gradle DSL currently and it has many advantages over Groovy DSL. The eventmesh-admin-new module used Gradle DSL for comparison and will be deleted before merged if ok. Using Groovy DSL.

Modifications

  1. new feats

Subscription management functions are now available.

Connection management function will be finished after EventMesh K8s operator is supported.

  1. one change made to existing code

The toString method of Session now supports Json output in order to be displayed on eventmesh-dashboard.

Before:
image

After:
image

Todo

  • Delete HTTP subscription function.
  • Topic management functions in storage-plugin.admin will be migrated to eventmesh-admin.
  • Endpoints in runtime.admin will use Netty instead of Sun HttpServer.
  • Connection managment and etcd support.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia marked this pull request as draft October 2, 2023 10:00
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #4468 (db69ee5) into master (6dfd46d) will decrease coverage by 1.33%.
Report is 13 commits behind head on master.
The diff coverage is 2.73%.

❗ Current head db69ee5 differs from pull request most recent head 1941e31. Consider uploading reports for the commit 1941e31 to get more accurate results

@@             Coverage Diff              @@
##             master    #4468      +/-   ##
============================================
- Coverage     16.90%   15.57%   -1.33%     
- Complexity     1458     1475      +17     
============================================
  Files           621      698      +77     
  Lines         25825    28203    +2378     
  Branches       2415     2633     +218     
============================================
+ Hits           4365     4394      +29     
- Misses        21021    23361    +2340     
- Partials        439      448       +9     
Files Coverage Δ
...esh/admin/rocketmq/controller/AdminController.java 0.00% <ø> (ø)
...ventmesh/admin/rocketmq/handler/TopicsHandler.java 0.00% <ø> (ø)
...g/apache/eventmesh/common/ResetCountDownLatch.java 92.85% <ø> (ø)
...org/apache/eventmesh/common/ThreadPoolFactory.java 16.66% <ø> (ø)
...ava/org/apache/eventmesh/common/ThreadWrapper.java 59.64% <ø> (ø)
...e/eventmesh/common/config/CommonConfiguration.java 83.33% <ø> (ø)
.../eventmesh/common/config/convert/ConverterMap.java 71.73% <ø> (ø)
...common/config/convert/converter/ListConverter.java 54.16% <ø> (ø)
...mmon/config/convert/converter/ObjectConverter.java 59.77% <ø> (ø)
...entmesh/common/enums/EventMeshDataContentType.java 0.00% <ø> (ø)
... and 158 more

... and 193 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Pil0tXia Pil0tXia marked this pull request as ready for review October 2, 2023 18:28
@Pil0tXia Pil0tXia requested a review from mxsm October 2, 2023 18:28
@Pil0tXia Pil0tXia requested a review from xwm1992 October 3, 2023 17:12
xwm1992
xwm1992 previously approved these changes Oct 4, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit b6f9ca5 into apache:master Oct 6, 2023
7 checks passed
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
@Pil0tXia Pil0tXia deleted the pil0txia_module_4275 branch January 4, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support subscription info management with eventmesh-admin module
4 participants