-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4275] Support subscription info management with eventmesh-admin module #4468
Conversation
eventmesh-connectors/eventmesh-connector-rocketmq/src/main/resources/source-config.yml
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
============================================
- Coverage 16.90% 15.57% -1.33%
- Complexity 1458 1475 +17
============================================
Files 621 698 +77
Lines 25825 28203 +2378
Branches 2415 2633 +218
============================================
+ Hits 4365 4394 +29
- Misses 21021 23361 +2340
- Partials 439 448 +9
... and 193 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eventmesh-admin-new/src/main/java/org/apache/eventmesh/adminnew/EventmeshAdminApplication.java
Outdated
Show resolved
Hide resolved
...sh-admin-new/src/test/java/org/apache/eventmesh/adminnew/EventmeshAdminApplicationTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4275.
Motivation
This is a subtask of GLCC Subject #4040.
Design Document: https://docs.qq.com/doc/DSk9NU1JiRlBpSXln
eventmesh-admin
module is going to be substituted to be deployed independently. For now, a new moduleeventmesh-console
is added to migrate functions ofeventmesh-admin
gradually.TheUsing Groovy DSL.eventmesh-admin-kotlin
module used Gradle Kotlin DSL instead of Gradle Groovy DSL to manage dependencies, because Kotlin DSL is the default Gradle DSL currently and it has many advantages over Groovy DSL. Theeventmesh-admin-new
module used Gradle DSL for comparison and will be deleted before merged if ok.Modifications
Subscription management functions are now available.
Connection management function will be finished after EventMesh K8s operator is supported.
The
toString
method ofSession
now supports Json output in order to be displayed oneventmesh-dashboard
.Before:
After:
Todo
storage-plugin.admin
will be migrated toeventmesh-admin
.runtime.admin
will use Netty instead of Sun HttpServer.Documentation