Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] #4470

Closed
wants to merge 3 commits into from

Conversation

Monika-Sivakumar-3
Copy link
Contributor

Replace with lambda

Fixes #4088 .

Motivation

Replacing with lambda

Modifications

Replacing a function with lambda

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? Not applicable
  • If a feature is not applicable for documentation, explain why? Not applicable

Replace with lambda
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monika-Sivakumar-3 Please fix CI

Removed extra space
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please use the standard format for PR title by the way.

@Monika-Sivakumar-3 Monika-Sivakumar-3 changed the title Update BroadCastSubClient.java [Issue #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] Oct 4, 2023
@Alonexc
Copy link
Contributor

Alonexc commented Oct 7, 2023

image

Remove unused import
@xwm1992 xwm1992 changed the title [Issue #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] [ISSUE #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] Oct 9, 2023
@Alonexc
Copy link
Contributor

Alonexc commented Oct 10, 2023

Current pr seems to duplicate pr[ #4469].

@xwm1992
Copy link
Contributor

xwm1992 commented Oct 25, 2023

For there is no response, I'll close this pr and let others do this.

@xwm1992 xwm1992 closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Anonymous new can be replaced with lambda.[BroadCastSubClient]
5 participants