Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3397] Make field a static final constant or non-public #4471

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Monika-Sivakumar-3
Copy link
Contributor

Make field a static final constant or non-public

Fixes #3397.

Motivation

Make field a static final constant or non-public

Modifications

Make field a static final constant or non-public.

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? Not applicable
  • If a feature is not applicable for documentation, explain why? Not applicable

Make field a static final constant or non-public
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #4471 (c815b91) into master (73af459) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head c815b91 differs from pull request most recent head ee4ad99. Consider uploading reports for the commit ee4ad99 to get more accurate results

@@             Coverage Diff              @@
##             master    #4471      +/-   ##
============================================
- Coverage     15.58%   15.56%   -0.02%     
  Complexity     1475     1475              
============================================
  Files           698      698              
  Lines         28197    28186      -11     
  Branches       2633     2616      -17     
============================================
- Hits           4394     4388       -6     
+ Misses        23355    23351       -4     
+ Partials        448      447       -1     
Files Coverage Δ
.../tcp/client/session/push/DownStreamMsgContext.java 0.00% <ø> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please edit your PR title to the standard format.

@Monika-Sivakumar-3 Monika-Sivakumar-3 changed the title Update DownStreamMsgContext.java [ISSUE #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] Oct 4, 2023
@Monika-Sivakumar-3 Monika-Sivakumar-3 changed the title [ISSUE #4088] Anonymous new can be replaced with lambda.[BroadCastSubClient] [ISSUE #3397] Make field a static final constant or non-public Oct 4, 2023
@xwm1992 xwm1992 merged commit 05900d0 into apache:master Oct 4, 2023
@pandaapo pandaapo mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make field a static final constant or non-public
4 participants