Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4458] Support MySQL Sink Connector feature #4771

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Feb 17, 2024

Fixes #4458

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

  • Support mysql Sink Connector feature

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 1474 lines in your changes are missing coverage. Please review.

Comparison is base (648f3e9) 0.00% compared to head (57a8eaf) 16.38%.

Files Patch % Lines
...tor/jdbc/sink/handle/DefaultSinkRecordHandler.java 0.00% 174 Missing ⚠️
...r/jdbc/sink/handle/GeneralDialectAssemblyLine.java 0.00% 133 Missing ⚠️
...eventmesh/connector/jdbc/table/catalog/Column.java 0.00% 87 Missing ⚠️
...mysql/listener/ColumnDefinitionParserListener.java 0.00% 78 Missing ⚠️
.../catalog/mysql/MysqlDefaultValueConvertorImpl.java 0.00% 78 Missing ⚠️
...ector/jdbc/dialect/mysql/MysqlDatabaseDialect.java 0.00% 61 Missing ⚠️
...r/jdbc/dialect/AbstractGeneralDatabaseDialect.java 0.00% 56 Missing ⚠️
.../eventmesh/connector/jdbc/table/catalog/Index.java 0.00% 51 Missing ⚠️
...entmesh/connector/jdbc/sink/JdbcSinkConnector.java 0.00% 38 Missing ⚠️
.../eventmesh/connector/jdbc/table/catalog/Table.java 0.00% 33 Missing ⚠️
... and 88 more
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4771       +/-   ##
=============================================
+ Coverage          0   16.38%   +16.38%     
- Complexity        0     1734     +1734     
=============================================
  Files             0      854      +854     
  Lines             0    31253    +31253     
  Branches          0     2700     +2700     
=============================================
+ Hits              0     5120     +5120     
- Misses            0    25653    +25653     
- Partials          0      480      +480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm changed the title [ISSUE #]Support mysql Sink Connector feature [ISSUE #4458]Support mysql Sink Connector feature Feb 18, 2024
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia changed the title [ISSUE #4458]Support mysql Sink Connector feature [ISSUE #4458] Support MySQL Sink Connector feature Feb 18, 2024
@Pil0tXia
Copy link
Member

Pil0tXia commented Feb 18, 2024

The module this PR developing is JDBC Connector, and the PR title is MySQL Sink Connector. Is that because current implement only supports MySQL?

@Pil0tXia Pil0tXia merged commit d6393ab into apache:master Feb 18, 2024
11 checks passed
@mxsm
Copy link
Member Author

mxsm commented Feb 18, 2024

The module this PR developing is JDBC Connector, and the PR title is MySQL Sink Connector. Is that because current implement only supports MySQL?

Yes, Additional implementations for other databases such as PostgreSQL and Oracle will be added later. The overall framework code has been mostly completed, and future implementations for other databases will only require adding some database-specific processing.

@mxsm mxsm deleted the eventmesh-jdbc-mysql-sink branch March 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support mysql Sink Connector feature
3 participants