Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3828] Code optimization for StandaloneAdminTest and TestUtils #4784

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

dr-divago
Copy link
Contributor

Fixes #3828

Motivation

Optimize code in the following classes : StandaloneAdminTest and TestUtils

Modifications

Remove duplication
Use native Boolean.TRUE and Boolean.FALSE instead of variable with value true and false
Use Collections.singletonList for creating List

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why? Optimization in tests
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.34%. Comparing base (713f7c6) to head (35c9589).

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4784       +/-   ##
=============================================
+ Coverage          0   16.34%   +16.34%     
- Complexity        0     1734     +1734     
=============================================
  Files             0      856      +856     
  Lines             0    31244    +31244     
  Branches          0     2698     +2698     
=============================================
+ Hits              0     5106     +5106     
- Misses            0    25659    +25659     
- Partials          0      479      +479     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia Pil0tXia merged commit c700a64 into apache:master Mar 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Do some code optimization.[StandaloneAdminTest TestUtils]
3 participants