Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4785] Condition check for source worker #4786

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

manojks1999
Copy link
Contributor

@manojks1999 manojks1999 commented Mar 7, 2024

Fixes #4785

  • Minor change in condition as per description.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@fabian4
Copy link
Member

fabian4 commented Mar 8, 2024

Please check the CI (fix the import statement order)
for reference https://eventmesh.apache.org/community/contribute/contribute/#code-style

image

@manojks1999
Copy link
Contributor Author

Changes were made, pls have a look.

Copy link
Member

@fabian4 fabian4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@harshithasudhakar harshithasudhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandaapo pandaapo merged commit 0250a89 into apache:master Mar 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the condition checking in SourceWorker#startPollAndSend
4 participants