Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4799] Change the logging level of msg ignored from error to warn #4803

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[ISSUE #4799] Change the logging level of msg ignored from error to warn #4803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ protected void channelRead0(ChannelHandlerContext ctx, Package msg) throws Excep
contexts.remove(context.getKey());
context.finish(msg);
} else {
log.error("msg ignored,context not found .|{}|{}", cmd, msg);
log.warn("msg ignored,context not found.|{}|{}", cmd, msg);
}
} else if (cmd == Command.SERVER_GOODBYE_REQUEST) {
log.error("server goodbye request: ---------------------------{}", msg);
Expand All @@ -206,7 +206,7 @@ protected void channelRead0(ChannelHandlerContext ctx, Package msg) throws Excep
contexts.remove(context.getKey());
context.finish(msg);
} else {
log.error("msg ignored,context not found .|{}|{}", cmd, msg);
log.warn("msg ignored,context not found.|{}|{}", cmd, msg);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/SubClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ protected void channelRead0(ChannelHandlerContext ctx, Package msg) throws Excep
contexts.remove(context.getKey());
context.finish(msg);
} else {
log.error("msg ignored,context not found.|{}|{}", cmd, msg);
log.warn("msg ignored,context not found.|{}|{}", cmd, msg);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...va/src/main/java/org/apache/eventmesh/client/tcp/impl/AbstractEventMeshTCPSubHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ protected void channelRead0(ChannelHandlerContext ctx, Package msg) throws Excep
// TODO
break;
default:
log.error("msg ignored|{}|{}", cmd, msg);
log.warn("msg ignored|{}|{}", cmd, msg);
}
RequestContext context = contexts.get(RequestContext.key(msg));
if (context != null) {
contexts.remove(context.getKey());
context.finish(msg);
} else {
log.error("msg ignored,context not found.|{}|{}", cmd, msg);
log.warn("msg ignored,context not found.|{}|{}", cmd, msg);
}
}

Expand Down
Loading