Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4805] Rethrow exception in gRPC SDK when publish error occurs #4806

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Apr 2, 2024

Fixes #4805

Motivation

Please see #4805.

Modifications

Add a new throws new EventMeshException statement in the catch block, just like the org.apache.eventmesh.client.http.AbstractProducerHttpClient#publish and the org.apache.eventmesh.client.tcp.impl.eventmeshmessage.EventMeshMessageTCPPubClient#publish did.

In eventmesh-sdk-java, this exception is not handled by the caller of the publish(EventMeshMessage message) method. If the exception is rethrown, the user must catch this exception manually.

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia requested a review from mxsm April 2, 2024 08:37
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 16.33%. Comparing base (172804a) to head (26cdd00).

Files Patch % Lines
...client/grpc/producer/EventMeshMessageProducer.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4806       +/-   ##
=============================================
+ Coverage          0   16.33%   +16.33%     
- Complexity        0     1734     +1734     
=============================================
  Files             0      856      +856     
  Lines             0    31253    +31253     
  Branches          0     2697     +2697     
=============================================
+ Hits              0     5106     +5106     
- Misses            0    25668    +25668     
- Partials          0      479      +479     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia Pil0tXia merged commit 1887cd6 into apache:master Apr 5, 2024
11 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia/bug_4805 branch April 5, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventMeshMessageProducer exceptions swallowed problem
3 participants