[ISSUE #5039]support full sync of mysql #5038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodaRyCN
changed the title
xwm1992
approved these changes
Jul 23, 2024
wqliang
approved these changes
Jul 23, 2024
Pil0tXia
reviewed
Jul 23, 2024
Comment on lines
+38
to
+40
| implementation "com.alibaba:druid-spring-boot-starter" | ||
| implementation 'com.mysql:mysql-connector-j' | ||
| compileOnly 'org.projectlombok:lombok' |
There was a problem hiding this comment.
mysql-connector-j artifact with implementation namespace introduces incompatible license.
I will submit a PR and add The GNU General Public License, v2 with Universal FOSS Exception, v1.0 in deniedLicenses later.
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5039
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation