-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Felix Android Support #155
Open
phinney
wants to merge
10,000
commits into
apache:trunk
Choose a base branch
from
phinney:trunk
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830167 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830169 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830256 13f79535-47bb-0310-9956-ffa450edef68
…1.0.0 git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830291 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830293 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830295 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830298 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830711 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830726 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830760 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830762 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830828 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830830 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830831 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830834 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830835 13f79535-47bb-0310-9956-ffa450edef68
…5.9.0-SNAPSHOT git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830838 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830839 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830893 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830895 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830896 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830898 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830903 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830904 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1830906 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1831154 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1831169 13f79535-47bb-0310-9956-ffa450edef68
…roxy broken git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1831192 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1831246 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1831297 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838233 13f79535-47bb-0310-9956-ffa450edef68
…ption. Apply patch from David Nebinger git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838410 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838506 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838507 13f79535-47bb-0310-9956-ffa450edef68
…type. Apply patch from Simone Tripodi git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838543 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838564 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838769 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838966 13f79535-47bb-0310-9956-ffa450edef68
… on Android git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838972 13f79535-47bb-0310-9956-ffa450edef68
…tions more gracefully git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1838974 13f79535-47bb-0310-9956-ffa450edef68
Signed-off-by: Raymond Auge <rotty3000@apache.org> git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1839365 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1839448 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1839450 13f79535-47bb-0310-9956-ffa450edef68
Add DexBundleClassLoader for android support
added new config entry FelixConstants.FELIX_REQUIRE_DEX_PROPERTY)
@phinney, judging by your documentation it sounds like you are going into the right direction - however, for some reason your PR doesn't seem right. Somehow, the files seems to have duplicated information in them or something. Could you please have another look and see if you can clean them up (either in this PR or by creating a new one)? |
This reverts commit cadcc5f.
This reverts commit bbe0a0dd871168715034ccff74426bcc1bd0c018.
Karl,
I think I got it straighten out! As you might as well figured out, I’m not all that skillful using GitHub. I thought I could just edit the file an do a select all, and paste, but I see that’s not the case in GitHub. A search on the internet reveals I not the only one confused by that.
I been using the code with the changes and it has been pretty solid. As far as native code testing, I’ve verified that source code is copied out of the bundle and stored in the directory for the BundleRevison and that the proper directory paths has been added to the PathClassLoader. I’ve not actually invoked a native library method; that mechanism should however work as it has in the past. I will sometime in the future actually call a native library method and verify the full process. If you have an android bundle that contains native code for me to test that would be helpful.
…-Tom Rutchik
From: Karl Pauls [mailto:notifications@github.com]
Sent: Tuesday, September 18, 2018 12:47 PM
To: apache/felix <felix@noreply.github.com>
Cc: Tom Rutchik <tom@PhinneyRIdge.com>; Mention <mention@noreply.github.com>
Subject: Re: [apache/felix] Felix Android Support (#155)
@phinney <https://github.com/phinney> , judging by your documentation it sounds like you are going into the right direction - however, for some reason your PR doesn't seem right. Somehow, the files seems to have duplicated information in them or something. Could you please have another look and see if you can clean them up (either in this PR or by creating a new one)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#155 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHYfdDpEY7oQlATxPIsYbM7pSYPLI9_Uks5ucU2ygaJpZM4WsQzU> . <https://github.com/notifications/beacon/AHYfdOjU0wuuLqq2jkNx0g5vEDbGfhnQks5ucU2ygaJpZM4WsQzU.gif>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three files changed: BundleWiringImpl, FelixConstansts and Felix
BundleRevisionImpl was unintentionally committed, and then re-committed back to its original state. I couldn't find a why to revoke the unintentional commit.
The attached file contains documentation explaining the implementation changes
Apache Project.pdf