-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
FINERACT-2081: fix loan creation validations
- Loading branch information
Showing
2 changed files
with
160 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 135 additions & 0 deletions
135
...sts/src/test/java/org/apache/fineract/integrationtests/LoanValidationIntegrationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.fineract.integrationtests; | ||
|
|
||
| import com.jayway.jsonpath.DocumentContext; | ||
| import com.jayway.jsonpath.JsonPath; | ||
| import io.restassured.builder.RequestSpecBuilder; | ||
| import io.restassured.builder.ResponseSpecBuilder; | ||
| import io.restassured.http.ContentType; | ||
| import io.restassured.specification.RequestSpecification; | ||
| import io.restassured.specification.ResponseSpecification; | ||
| import java.util.Collections; | ||
| import net.minidev.json.JSONArray; | ||
| import org.apache.fineract.integrationtests.common.ClientHelper; | ||
| import org.apache.fineract.integrationtests.common.Utils; | ||
| import org.apache.fineract.integrationtests.common.accounting.Account; | ||
| import org.apache.fineract.integrationtests.common.accounting.AccountHelper; | ||
| import org.apache.fineract.integrationtests.common.loans.LoanApplicationTestBuilder; | ||
| import org.apache.fineract.integrationtests.common.loans.LoanProductTestBuilder; | ||
| import org.apache.fineract.integrationtests.common.loans.LoanTestLifecycleExtension; | ||
| import org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper; | ||
| import org.apache.fineract.integrationtests.common.organisation.StaffHelper; | ||
| import org.apache.fineract.integrationtests.useradministration.users.UserHelper; | ||
| import org.hamcrest.BaseMatcher; | ||
| import org.hamcrest.Description; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @ExtendWith(LoanTestLifecycleExtension.class) | ||
| public class LoanValidationIntegrationTest { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(LoanValidationIntegrationTest.class); | ||
|
|
||
| private RequestSpecification requestSpec; | ||
| private ResponseSpecification responseSpec; | ||
| private LoanTransactionHelper loanTransactionHelper; | ||
| private AccountHelper accountHelper; | ||
|
|
||
| @BeforeEach | ||
| public void setup() { | ||
| Utils.initializeRESTAssured(); | ||
| this.requestSpec = new RequestSpecBuilder().setContentType(ContentType.JSON).build(); | ||
| this.requestSpec.header("Authorization", "Basic " + Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey()); | ||
| this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200).build(); | ||
| this.loanTransactionHelper = new LoanTransactionHelper(this.requestSpec, this.responseSpec); | ||
| this.accountHelper = new AccountHelper(this.requestSpec, this.responseSpec); | ||
| } | ||
|
|
||
| @Test | ||
| public void checkPrincipalErrors() { | ||
| final Integer staffId = StaffHelper.createStaff(this.requestSpec, this.responseSpec); | ||
| String username = Utils.uniqueRandomStringGenerator("user", 8); | ||
| UserHelper.createUser(this.requestSpec, this.responseSpec, 1, staffId, username, "P4ssw0rd", "resourceId"); | ||
|
|
||
| LOG.info("-------------------------Creating Client---------------------------"); | ||
| final Integer clientID = ClientHelper.createClient(requestSpec, responseSpec); | ||
| ClientHelper.verifyClientCreatedOnServer(requestSpec, responseSpec, clientID); | ||
|
|
||
| LOG.info("-------------------------Creating Loan---------------------------"); | ||
| final Account assetAccount = this.accountHelper.createAssetAccount(); | ||
| final Account incomeAccount = this.accountHelper.createIncomeAccount(); | ||
| final Account expenseAccount = this.accountHelper.createExpenseAccount(); | ||
| final Account overpaymentAccount = this.accountHelper.createLiabilityAccount(); | ||
|
|
||
| LOG.info("------------------------------CREATING NEW LOAN PRODUCT ---------------------------------------"); | ||
| final String loanProductJSON = new LoanProductTestBuilder() // | ||
| .withPrincipal("10000000.00") // | ||
| .withNumberOfRepayments("24") // | ||
| .withRepaymentAfterEvery("1") // | ||
| .withRepaymentTypeAsMonth() // | ||
| .withinterestRatePerPeriod("2") // | ||
| .withInterestRateFrequencyTypeAsMonths() // | ||
| .withRepaymentStrategy(LoanProductTestBuilder.DEFAULT_STRATEGY) // | ||
| .withAmortizationTypeAsEqualPrincipalPayment() // | ||
| .withInterestTypeAsDecliningBalance() // | ||
| .currencyDetails("0", "0") | ||
| .withAccounting("2", new Account[] { assetAccount, incomeAccount, expenseAccount, overpaymentAccount }).build(null); | ||
| final Integer loanProductID = this.loanTransactionHelper.getLoanProductId(loanProductJSON); | ||
|
|
||
| LOG.info("--------------------------------APPLYING FOR LOAN APPLICATION--------------------------------"); | ||
| final String loanApplicationJSON = new LoanApplicationTestBuilder() // | ||
| .withPrincipal("-1") // | ||
| .withLoanTermFrequency("6") // | ||
| .withLoanTermFrequencyAsMonths() // | ||
| .withNumberOfRepayments("6") // | ||
| .withRepaymentEveryAfter("1") // | ||
| .withRepaymentFrequencyTypeAsMonths() // | ||
| .withInterestRatePerPeriod("2") // | ||
| .withAmortizationTypeAsEqualInstallments() // | ||
| .withInterestTypeAsFlatBalance() // | ||
| .withInterestCalculationPeriodTypeSameAsRepaymentPeriod() // | ||
| .withExpectedDisbursementDate("12 July 2022") // | ||
| .withSubmittedOnDate("10 July 2022") // | ||
| .withRepaymentStrategy(LoanApplicationTestBuilder.DEFAULT_STRATEGY) // | ||
| .withCharges(Collections.emptyList()) // | ||
| .build(clientID.toString(), loanProductID.toString(), null); | ||
|
|
||
| ResponseSpecification failedResponseSpec = new ResponseSpecBuilder().expectStatusCode(400).expectBody(new BaseMatcher<String>() { | ||
|
|
||
| @Override | ||
| public boolean matches(Object body) { | ||
| DocumentContext json = JsonPath.parse(body.toString()); | ||
| LOG.error(body.toString()); | ||
| JSONArray errors = json.read("$.errors[*].developerMessage"); | ||
| LOG.info("errors: {}", errors); | ||
| return errors.size() == 1; | ||
| } | ||
|
|
||
| @Override | ||
| public void describeTo(Description description) { | ||
|
|
||
| } | ||
| }).build(); | ||
| final Integer loanID = this.loanTransactionHelper.getLoanId(loanApplicationJSON, requestSpec, failedResponseSpec); | ||
| } | ||
| } |