FINERACT-1806: Charge-off Expense Accounting entries based on charge-off reason instead of fraud flag #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
ad84a5b
to
8ecfc1f
Compare
adamsaghy
reviewed
Nov 6, 2024
fineract-core/src/main/java/org/apache/fineract/accounting/common/AccountingRuleType.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 6, 2024
...ounting/productaccountmapping/service/ProductToGLAccountMappingWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 6, 2024
...ounting/productaccountmapping/service/ProductToGLAccountMappingWritePlatformServiceTest.java
Outdated
Show resolved
Hide resolved
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
8ecfc1f
to
c392b6b
Compare
adamsaghy
reviewed
Nov 7, 2024
...e/fineract/accounting/productaccountmapping/service/LoanProductToGLAccountMappingHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 7, 2024
...ounting/productaccountmapping/service/ProductToGLAccountMappingWritePlatformServiceImpl.java
Show resolved
Hide resolved
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
4 times, most recently
from
8712a40
to
69b3aa1
Compare
adamsaghy
reviewed
Nov 14, 2024
.../fineract/accounting/producttoaccountmapping/domain/ProductToGLAccountMappingRepository.java
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 14, 2024
...accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformService.java
Outdated
Show resolved
Hide resolved
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
6 times, most recently
from
ea314a8
to
55df1c7
Compare
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
55df1c7
to
d3478ff
Compare
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
d3478ff
to
8e9e4ab
Compare
adamsaghy
reviewed
Nov 18, 2024
...n/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 18, 2024
...resources/db/changelog/tenant/parts/0153_add_charge_off_reason_id_to_acc_product_mapping.xml
Show resolved
Hide resolved
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
8e9e4ab
to
59afcb9
Compare
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
2 times, most recently
from
2c8773f
to
6598a51
Compare
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
6598a51
to
e68898e
Compare
adamsaghy
reviewed
Nov 21, 2024
...che/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 21, 2024
...che/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 21, 2024
...che/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 21, 2024
...resources/db/changelog/tenant/parts/0153_add_charge_off_reason_id_to_acc_product_mapping.xml
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 21, 2024
...tion-tests/src/test/java/org/apache/fineract/integrationtests/ClientLoanIntegrationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 21, 2024
...c/test/java/org/apache/fineract/integrationtests/LoanProductChargeOffReasonMappingsTest.java
Outdated
Show resolved
Hide resolved
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
e68898e
to
9532811
Compare
adamsaghy
reviewed
Nov 21, 2024
...che/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java
Show resolved
Hide resolved
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
9532811
to
7674252
Compare
…nced Accounting Rule"
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
7674252
to
b9a9a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charge-off Expense Accounting entries based on charge-off reason instead of fraud flag
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.