HDFS-17105. mistakenly purge editLogs even after it is empty in NNSto…

…rageRetentionManager. (#6036). Contributed by ConfX. Signed-off-by: He Xiaoqiao <[email protected]>
apache · Sep 20, 2023 · 39f36d9 · 39f36d9
1 parent 512e39e
commit 39f36d9
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java b/...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java
@@ -80,6 +80,9 @@ public NNStorageRetentionManager(
     Preconditions.checkArgument(numExtraEditsToRetain >= 0,
         DFSConfigKeys.DFS_NAMENODE_NUM_EXTRA_EDITS_RETAINED_KEY +
         " must not be negative");
+    Preconditions.checkArgument(maxExtraEditsSegmentsToRetain >= 0,
+        DFSConfigKeys.DFS_NAMENODE_MAX_EXTRA_EDITS_SEGMENTS_RETAINED_KEY +
+        " must not be negative");
 
     this.storage = storage;
     this.purgeableLogs = purgeableLogs;