HADOOP-18954. Filter NaN values from JMX json interface #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The JMX json represents NaN like invalid JSON token, so some parser can not parse. - To fix this a new feature introduced to replace NaN with 0.0 values. - The feature can be turned on with the hadoop.http.jmx.nan-filter.enabled config
ferdelyi
approved these changes
Oct 27, 2023
|
LGTM, thank you for your work on this! |
|
💔 -1 overall
This message was automatically generated. |
|
Check style says but I think we should rather keep it like this cause the other variables like this neither have getter / setter. |
- replace constants place
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Nov 2, 2023
There was a problem hiding this comment.
@K0K0V0K Thanks for your contribution. Leave one nit comment inline. FYI.
| result = readOutput(new URL(baseUrl, "/jmx")); | ||
| assertReFind("\"name\"\\s*:\\s*\"java.lang:type=Memory\"", result); | ||
|
|
||
| assertReFind( |
There was a problem hiding this comment.
How about add another case to verify the result when enable JMX_NAN_FILTER?
There was a problem hiding this comment.
Hi @Hexiaoqiao !
Thanks for the review!
Yes, I think it would be good to have a test like that, but that change just won't be nice I am afraid.
The problem is that there is no nice way to connect the HttpServerFunctionalTest#createTestServer(Configuration conf) to the JMXJsonServlet, cause in the HttpServlet2#addDefaultServlets we just provide class reference.
A possible solution is to create another JMX servlet class to do the trick.
I would prefer the previous code, cause that was less ugly, but I am open to keeping this one, to have the test.
There was a problem hiding this comment.
Got it. Make sense to me.
|
💔 -1 overall
This message was automatically generated. |
|
@K0K0V0K Please check the report from Yetus if we need to fix checkstyle and javadoc/blanks. Thanks. |
|
💔 -1 overall
This message was automatically generated. |
Hexiaoqiao
approved these changes
Nov 9, 2023
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Reviewed-by: Ferenc Erdelyi Signed-off-by: He Xiaoqiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?