-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17588. RBF: RouterObserverReadProxyProvider should perform an msync before executing the first read. #6956
base: trunk
Are you sure you want to change the base?
Conversation
…xecuting the first read.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@simbadzina Master, please help me review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Sorry for taking so long to review. I haven't had much bandwidth for the last few months.
A number of tests in TestObserverWithRouter
start to fail due to the extra msync. The counts of operations needs to be adjusted for these tests.
I don't know why the CI didn't run this class: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6956/3/testReport/org.apache.hadoop.hdfs.server.federation.router/
@simbadzina testRestartingNamenodeWithStateIDContextDisabled failed due to stateID=0,HDFS-17514 allows passing stateID=0, I wonder if this can be fixed? |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testRestartingNamenodeWithStateIDContextDisabled
fails with the RouterObserverReadProxy provider.
@simbadzina Sir, |
🎊 +1 overall
This message was automatically generated. |
When using RouterObserverReadProxyProvider to initiate the first RPC request, the router routes this RPC to the active namenode and updates the stateid of the corresponding nameservice. However, the stateid of other nameservices is not updated. Clients should first perform msync to update the stateid of all nameservices with enabled Observers before executing the first read.