HADOOP-19362. RPC metrics should be updated correctly when call is defered. #7224
+139
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfutatzhanghb
force-pushed
the
HADOOP-19362
branch
from
24c1de0 to
9bee480
Compare
hfutatzhanghb
force-pushed
the
HADOOP-19362
branch
from
9bee480 to
e201bfc
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@Hexiaoqiao @KeeProMise @haiyang1987 Sir, could you please help review this PR when you are free ? Thanks a lot. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
reviewed
Dec 12, 2024
There was a problem hiding this comment.
@hfutatzhanghb Hi, thanks for your contribution! leave some comments.
Comment on lines
+683
to
+712
| */ | ||
| void updateDeferredMetrics(Call call, String name, long processingTime) { | ||
| long completionTimeNanos = Time.monotonicNowNanos(); | ||
| long arrivalTimeNanos = call.timestampNanos; | ||
|
|
||
| ProcessingDetails details = call.getProcessingDetails(); | ||
| long waitTime = | ||
| details.get(Timing.LOCKWAIT, rpcMetrics.getMetricsTimeUnit()); | ||
| long responseTime = | ||
| details.get(Timing.RESPONSE, rpcMetrics.getMetricsTimeUnit()); | ||
| rpcMetrics.addRpcLockWaitTime(waitTime); | ||
| rpcMetrics.addRpcProcessingTime(processingTime); | ||
| rpcMetrics.addRpcResponseTime(responseTime); | ||
| rpcMetrics.addDeferredRpcProcessingTime(processingTime); | ||
| rpcDetailedMetrics.addDeferredProcessingTime(name, processingTime); | ||
| // don't include lock wait for detailed metrics. | ||
| processingTime -= waitTime; | ||
| rpcDetailedMetrics.addProcessingTime(name, processingTime); | ||
|
|
||
| // Overall processing time is from arrival to completion. | ||
| long overallProcessingTime = rpcMetrics.getMetricsTimeUnit() | ||
| .convert(completionTimeNanos - arrivalTimeNanos, TimeUnit.NANOSECONDS); | ||
| rpcDetailedMetrics.addOverallProcessingTime(name, overallProcessingTime); | ||
| callQueue.addResponseTime(name, call, details); | ||
| if (isLogSlowRPC()) { | ||
| logSlowRpcCalls(name, call, details); | ||
| } | ||
| if (details.getReturnStatus() == RpcStatusProto.SUCCESS) { | ||
| rpcMetrics.incrRpcCallSuccesses(); | ||
| } |
There was a problem hiding this comment.
There is some duplicate code in this method and updateMetrics; we can extract the common code.
There was a problem hiding this comment.
@KeeProMise Sir, thanks for your reviewing. This is a good suggestion, but i am worrying about the code readability will not be good. What's your opinion？
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine2.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
KeeProMise
reviewed
Dec 13, 2024
Comment on lines
355
to
356
| private static final ThreadLocal<Long> CUR_CALL_STARTNANOS = new ThreadLocal<Long>(); | ||
|
|
There was a problem hiding this comment.
CUR_CALL_STARTNANOS Can it be deleted directly?
There was a problem hiding this comment.
Yes, Have fixed~ Thanks a lot.
KeeProMise
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
@hfutatzhanghb LGTM.
Hi, @Hexiaoqiao if you have time, please help to take a look at this PR, thanks!
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently, RPC processing metrics and some other metrics were not updated when a RpcCall was defered.
This will cause FairCallQueue not works well. So, We should take defered calls as normal calls.