-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28597: Upgrade to 8.4.3 LTS version of MySQL #5525
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending green build
In Jenkins, it is failing to download the newer image due to missing signature key. This seems like a client side issue due to some restriction on downloading Docker image. I checked that the earlier changes to mysql version only updated the version, and nothing related to docker. Could you please help with this environmental issue? Thanks.
Update 1: checking if docker client version is the issue Update 2: checking if docker server is at older version and client is at newer version
From this, the older server might be causing this issue. @deniskuzZ Could you please help on how to upgrade the docker server version on these VMs? |
2361b8b
to
7da03a9
Compare
7da03a9
to
7d42459
Compare
7d42459
to
18c4e92
Compare
18c4e92
to
264545e
Compare
i don't have access to the VMs, but I think @abstractdog can help |
itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java
Outdated
Show resolved
Hide resolved
itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/MySQLExternalDB.java
Show resolved
Hide resolved
it should work I believe...anyway, I can take a look this week |
264545e
to
443e182
Compare
Quality Gate passedIssues Measures |
guys, I've set this blocked on HIVE-28629, which is about to bump the dind image version |
@abstractdog Could you please prioritize HIVE-28629 since this is blocked on it? Thanks. |
What changes were proposed in this pull request?
Upgrade MySQL version
Why are the changes needed?
HIVE-28597
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=qt_database_mysql.q -pl itests/qtest -Pitests