Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "HIVE-28417: Bump Log4j2 to 2.24.1 to facilitate compilation of GraalVM Native Image" #5532

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

zhangbutao
Copy link
Contributor

@zhangbutao zhangbutao commented Nov 6, 2024

Reverts #5375

Try to resolve HIVE-28611

@github-actions github-actions bot requested a review from pgaref November 6, 2024 08:26
@zhangbutao zhangbutao removed the request for review from pgaref November 6, 2024 08:40
Copy link

sonarcloud bot commented Nov 6, 2024

Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangbutao zhangbutao marked this pull request as ready for review November 6, 2024 10:36
Copy link
Contributor

@okumin okumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this would correctly revert https://github.com/apache/hive/pull/5375/files

@zhangbutao
Copy link
Contributor Author

#5530 is trying to fix the skipped tests issue by upgrading Maven SureFire Plugin. Let's disscuss if we can merge #5530 to fix the issue.

@deniskuzZ deniskuzZ merged commit 1789f93 into master Nov 6, 2024
11 checks passed
@deniskuzZ deniskuzZ deleted the revert-5375-log4j-bump branch November 6, 2024 15:04
@deniskuzZ
Copy link
Member

deniskuzZ commented Nov 6, 2024

@zhangbutao, I've reverted to unblock everyone. original upgrade PR is supposed to have that change.

@zhangbutao
Copy link
Contributor Author

@zhangbutao, I've reverted to unblock everyone. original upgrade PR is supposed to have that change.

No problem we can revert it first. we can continue to test HIVE-28417 after HIVE-28519 is merged.

Indhumathi27 added a commit to Indhumathi27/hive that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants