[HUDI-8560] Revert HUDI-8036 #12303
Open
[HUDI-8560] Revert HUDI-8036 #12303
+101
−429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
requested changes
Nov 26, 2024
| assertEquals(metaClient.getTableConfig.getPartitionFieldProp, HoodieTableConfig.getPartitionFieldPropForKeyGenerator(metaClient.getTableConfig).orElse("")) | ||
| } | ||
| } | ||
| withTempDir { tmp => |
There was a problem hiding this comment.
These changes are much more than what's in #11710. Could you strictly revert what's changed?
github-actions
bot
added
size:L
yihua
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
HUDI-8036 changed the output schema and treated a symptom of the real issue but not the issue itself.
The root of the issue is that we are not parsing the partition path correctly and into the correct data types. This will be fixed in subsequent prs
I also had to modify the complex keygen sql tests a bit because now the correct partition column value and data type occurs
Impact
Spark reads timestamp partition cols in their correct datatype
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist