refact: fix some code style with check plugin #385

seagle-yuan · 2022-11-28T08:32:42Z

fix checkstyle check

codecov · 2022-11-28T09:09:15Z

Codecov Report

Attention: Patch coverage is 24.48980% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 62.54%. Comparing base (0a72868) to head (c410bb7).
Report is 94 commits behind head on master.

Files	Patch %	Lines
.../hugegraph/loader/flink/HugeGraphOutputFormat.java	0.00%	11 Missing ⚠️
...e/hugegraph/loader/spark/HugeGraphSparkLoader.java	0.00%	11 Missing ⚠️
...e/hugegraph/serializer/direct/HBaseSerializer.java	0.00%	8 Missing ⚠️
...e/hugegraph/serializer/direct/reuse/BytesDemo.java	0.00%	6 Missing ⚠️
...rg/apache/hugegraph/exception/ServerException.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #385      +/-   ##
============================================
- Coverage     62.58%   62.54%   -0.04%     
- Complexity      894     1866     +972     
============================================
  Files            91      260     +169     
  Lines          4383     9407    +5024     
  Branches        515      872     +357     
============================================
+ Hits           2743     5884    +3141     
- Misses         1437     3141    +1704     
- Partials        203      382     +179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin · 2022-11-28T09:44:32Z

hugegraph-client/src/main/java/org/apache/hugegraph/exception/ServerException.java

@@ -54,6 +58,7 @@ public static ServerException fromResponse(Response response) {
            exception.cause = (String) getByKeys(json, CAUSE_KEYS);
            exception.trace = getByKeys(json, TRACE_KEYS);
        } catch (Exception ignored) {
+            LOG.error(" ServerException excepiton ");


we need log here? @javeme

and seems have 2 extra spaces

hugegraph-dist/release-docs/licenses/LICENSE-ant-launcher.txt

hugegraph-dist/release-docs/licenses/LICENSE-ant.txt

imbajin · 2022-11-28T09:46:13Z

hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/config/HubbleConfig.java

@@ -57,6 +61,7 @@ public HugeConfig hugeConfig() {
                conf = path;
            }
        } catch (Exception ignored) {
+            LOG.error("hugeConfig exception");


same question

imbajin · 2022-11-28T09:46:49Z

hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/service/load/LoadTaskService.java

+                vMapping = new org.apache.hugegraph.loader.mapping.VertexMapping(
+                        idFields.get(0), true);


if line < 100, use one line instead

if one line,there is 105 char

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/flink/HugeGraphOutputFormat.java

imbajin · 2022-11-28T09:48:28Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java

+                request.vertices((List<Vertex>) (Object) graphElements)
+                        .updatingStrategies(updateStrategyMap)
+                        .createIfNotExist(true);


align problem?

imbajin · 2022-11-28T09:49:28Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java

+                        .updatingStrategies(updateStrategyMap)
+                        .checkVertex(isCheckVertex)
+                        .createIfNotExist(true);


same, and why we change the name? (seems optional)

imbajin · 2022-11-28T09:50:06Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java

+                    .updatingStrategies(this.mapping.updateStrategies())
+                    .createIfNotExist(true);


same, and so as others

imbajin · 2022-11-29T13:17:19Z

javeme · 2022-11-29T16:37:07Z

hugegraph-client/src/main/java/org/apache/hugegraph/exception/ServerException.java


 public class ServerException extends RuntimeException {

    private static final long serialVersionUID = 6335623004322652358L;

+    protected static final Logger LOG = Log.logger(ServerException.class);


mark as private?

javeme · 2022-11-29T16:37:38Z

hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/config/HubbleConfig.java

@@ -33,6 +35,8 @@
 @Configuration
 public class HubbleConfig {

+    protected static final Logger LOG = Log.logger(HubbleConfig.class);


javeme · 2022-11-29T16:38:27Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/flink/HugeGraphOutputFormat.java

-                        g.updateVertices(req.build());
+                        BatchVertexRequest.Builder request = new BatchVertexRequest.Builder();
+                        request.vertices((List<Vertex>) (Object) graphElements)
+                                .updatingStrategies(updateStrategyMap)


align with '.'

javeme · 2022-11-29T16:39:06Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java

-               .createIfNotExist(true);
+            BatchEdgeRequest.Builder request = new BatchEdgeRequest.Builder();
+            request.edges((List<Edge>) (Object) elements)
+                    .updatingStrategies(this.mapping.updateStrategies())


javeme · 2022-11-29T16:39:38Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java

-            "not allowed to insert, because already exist a vertex " +
+        "Connection refused",
+        "The server is being shutting down",
+        "not allowed to insert, because already exist a vertex " +


keep the origin style?

imbajin · 2022-12-10T16:54:28Z

@seagle-yuan will this PR fixed before release? (before next week) or just leave it in next release

github-actions · 2023-01-09T21:00:33Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

javeme · 2023-01-13T17:57:35Z

hugegraph-client/src/main/java/org/apache/hugegraph/serializer/direct/reuse/BytesDemo.java

+                add(peter);
+                add(lop);
+                add(vadasB);
+            }};


can we keep the origin style?

javeme · 2023-01-13T17:57:40Z

hugegraph-client/src/main/java/org/apache/hugegraph/serializer/direct/reuse/BytesDemo.java

-            add(peterCreateLop);
-        }};
+                add(peterCreateLop);
+            }};


can we keep the origin style?

github-actions · 2023-02-12T21:00:23Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2023-03-15T21:00:24Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2023-06-30T21:00:26Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

liuxiaocs7 · 2023-07-18T02:40:45Z

Hi, @seagle-yuan, any update with this?

imbajin · 2023-07-18T03:35:46Z

Hi, @seagle-yuan, any update with this?

could follow this PR and finish it

github-actions · 2023-08-17T21:00:29Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2024-02-22T21:00:32Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

codecov-commenter · 2024-04-14T18:06:02Z

Codecov Report

Attention: Patch coverage is 24.48980% with 37 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (0a72868) to head (c410bb7).
Report is 113 commits behind head on master.

Files with missing lines	Patch %	Lines
.../hugegraph/loader/flink/HugeGraphOutputFormat.java	0.00%	11 Missing ⚠️
...e/hugegraph/loader/spark/HugeGraphSparkLoader.java	0.00%	11 Missing ⚠️
...e/hugegraph/serializer/direct/HBaseSerializer.java	0.00%	8 Missing ⚠️
...e/hugegraph/serializer/direct/reuse/BytesDemo.java	0.00%	6 Missing ⚠️
...rg/apache/hugegraph/exception/ServerException.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #385      +/-   ##
============================================
- Coverage     62.58%   62.54%   -0.04%     
- Complexity      894     1866     +972     
============================================
  Files            91      260     +169     
  Lines          4383     9407    +5024     
  Branches        515      872     +357     
============================================
+ Hits           2743     5884    +3141     
- Misses         1437     3141    +1704     
- Partials        203      382     +179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-05-14T21:00:29Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2024-06-14T21:00:24Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2024-07-15T21:00:23Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

javeme · 2024-08-10T11:16:58Z

@imbajin could you move this PR forward?

imbajin · 2024-08-10T16:48:16Z

@imbajin could you move this PR forward?

@liuxiaocs7 is working on it but busy for now (hold it on)

Also this PR is not urgent(low priority)

github-actions · 2024-09-13T21:00:27Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2024-10-15T21:00:28Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

fix checkstyle check

da6a09e

imbajin reviewed Nov 28, 2022

View reviewed changes

yuanbingze and others added 3 commits November 28, 2022 18:29

delete blankspace

1816199

delete HugeGraphOutputFormat extra space

6eddbc8

Merge branch 'apache:master' into checkstyle

c410bb7

javeme reviewed Nov 29, 2022

View reviewed changes

imbajin changed the title ~~fix checkstyle check~~ refact: fix some code style with check plugin Dec 10, 2022

github-actions bot added the inactive label Jan 9, 2023

javeme removed the inactive label Jan 11, 2023

javeme reviewed Jan 13, 2023

View reviewed changes

github-actions bot added the inactive label Feb 12, 2023

javeme added ci Continuous integration and removed inactive labels Feb 13, 2023

github-actions bot added the inactive label Mar 15, 2023

javeme removed the inactive label May 31, 2023

github-actions bot added the inactive label Jun 30, 2023

javeme removed the inactive label Jul 1, 2023

liuxiaocs7 mentioned this pull request Aug 1, 2023

fix: checkstyle && add suppressions.xml #500

Merged

github-actions bot added the inactive label Aug 17, 2023

JackyYangPassion removed the inactive label Aug 19, 2023

github-actions bot added inactive and removed inactive labels Feb 22, 2024

imbajin marked this pull request as draft March 19, 2024 08:57

liuxiaocs7 marked this pull request as ready for review April 14, 2024 18:05

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. client hugegraph-client hubble hugegraph-hubble java Pull requests that update Java code loader hugegraph-loader tools hugegraph-tools labels Apr 14, 2024

liuxiaocs7 mentioned this pull request Apr 14, 2024

chore: followup checkstyle check #601

Draft

11 tasks

github-actions bot added inactive and removed inactive labels May 14, 2024

github-actions bot added inactive and removed inactive labels Jun 14, 2024

github-actions bot added inactive and removed inactive labels Jul 15, 2024

github-actions bot added inactive and removed inactive labels Sep 13, 2024

github-actions bot added inactive and removed inactive labels Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refact: fix some code style with check plugin #385

refact: fix some code style with check plugin #385

seagle-yuan commented Nov 28, 2022

codecov bot commented Nov 28, 2022 •

edited

Loading

imbajin Nov 28, 2022

imbajin Nov 28, 2022

imbajin Nov 28, 2022

seagle-yuan Nov 28, 2022

imbajin Nov 28, 2022

imbajin Nov 28, 2022

imbajin Nov 28, 2022

imbajin commented Nov 29, 2022

javeme Nov 29, 2022

javeme Nov 29, 2022

javeme Nov 29, 2022

javeme Nov 29, 2022

javeme Nov 29, 2022

imbajin commented Dec 10, 2022 •

edited

Loading

github-actions bot commented Jan 9, 2023

javeme Jan 13, 2023

javeme Jan 13, 2023

github-actions bot commented Feb 12, 2023

github-actions bot commented Mar 15, 2023

github-actions bot commented Jun 30, 2023

liuxiaocs7 commented Jul 18, 2023

imbajin commented Jul 18, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Feb 22, 2024

codecov-commenter commented Apr 14, 2024 •

edited by codecov bot

Loading

github-actions bot commented May 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jul 15, 2024

javeme commented Aug 10, 2024

imbajin commented Aug 10, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024

github-actions bot commented Oct 15, 2024

		vMapping = new org.apache.hugegraph.loader.mapping.VertexMapping(
		idFields.get(0), true);

		.updatingStrategies(this.mapping.updateStrategies())
		.createIfNotExist(true);

refact: fix some code style with check plugin #385

Are you sure you want to change the base?

refact: fix some code style with check plugin #385

Conversation

seagle-yuan commented Nov 28, 2022

codecov bot commented Nov 28, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imbajin commented Nov 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imbajin commented Dec 10, 2022 • edited Loading

github-actions bot commented Jan 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 12, 2023

github-actions bot commented Mar 15, 2023

github-actions bot commented Jun 30, 2023

liuxiaocs7 commented Jul 18, 2023

imbajin commented Jul 18, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Feb 22, 2024

codecov-commenter commented Apr 14, 2024 • edited by codecov bot Loading

Codecov Report

github-actions bot commented May 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jul 15, 2024

javeme commented Aug 10, 2024

imbajin commented Aug 10, 2024 • edited Loading

github-actions bot commented Sep 13, 2024

github-actions bot commented Oct 15, 2024

codecov bot commented Nov 28, 2022 •

edited

Loading

imbajin commented Dec 10, 2022 •

edited

Loading

codecov-commenter commented Apr 14, 2024 •

edited by codecov bot

Loading

imbajin commented Aug 10, 2024 •

edited

Loading