MakeConcrete always create an identityMap regardless of the equality behaviour

[lucamolteni]

Thank you for submitting this pull request

NOTE!: Double check the target branch for this PR.
The default is main so it will target Drools 8 / Kogito.
If this PR is not strictly related to drools and kogito project in drools.git, it should probably target 7.xas a branch

Ports If a forward-port or a backport is needed, paste the forward port PR here

link

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

• paste the link(s) from GitHub here
• link 2
• link 3 etc.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• for pull request checks
  Please add comment: Jenkins retest this

• for a specific pull request check
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

• for a full downstream build

  • for jenkins job: please add comment: Jenkins run fdb
  • for github actions job: add the label run_fdb

• a compile downstream build please add comment: Jenkins run cdb

• an upstream build please add comment: Jenkins run upstream

• for quarkus branch checks
  Run checks against Quarkus current used branch
  Please add comment: Jenkins run quarkus-branch

• for a quarkus branch specific check
  Run checks against Quarkus current used branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

• for quarkus main checks
  Run checks against Quarkus main branch
  Please add comment: Jenkins run quarkus-main

• for a specific quarkus main check
  Run checks against Quarkus main branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

• for quarkus lts checks
  Run checks against Quarkus lts branch
  Please add comment: Jenkins run quarkus-lts

• for a specific quarkus lts check
  Run checks against Quarkus lts branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

• for native checks
  Run native checks
  Please add comment: Jenkins run native

• for a specific native check
  Run native checks
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

• for native lts checks
  Run native checks against quarkus lts branch
  Please add comment: Jenkins run native-lts

• for a specific native lts check
  Run native checks against quarkus lts branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[tkobayas]

GHA: ubuntu java 11

2023-11-30T14:22:10.6884122Z [ERROR] Tests run: 56, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.775 s <<< FAILURE! -- in org.drools.mvel.integrationtests.ExpirationTest
2023-11-30T14:22:10.6886862Z [ERROR] org.drools.mvel.integrationtests.ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM[KieBase type=STREAM_IDENTITY] -- Time elapsed: 0.049 s <<< FAILURE!
2023-11-30T14:22:10.6888748Z org.junit.ComparisonFailure: expected:<[0]L> but was:<[1]L>
...
2023-11-30T14:27:25.6638223Z [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.304 s <<< FAILURE! -- in org.kie.pmml.evaluator.core.PMMLRuntimeContextImplTest
2023-11-30T14:27:25.6641123Z [ERROR] org.kie.pmml.evaluator.core.PMMLRuntimeContextImplTest.getFixedProbabilityMap -- Time elapsed: 0.005 s <<< ERROR!
2023-11-30T14:27:25.6642887Z java.lang.IllegalArgumentException: bound must be positive
2023-11-30T14:27:25.6643782Z    at java.base/java.util.Random.nextInt(Random.java:388)
2023-11-30T14:27:25.6645267Z    at org.kie.pmml.evaluator.core.PMMLRuntimeContextImplTest.lambda$getFixedProbabilityMap$0(PMMLRuntimeContextImplTest.java:92)
2023-11-30T14:27:25.6646850Z    at java.base/java.util.stream.IntPipeline$6$1.accept(IntPipeline.java:286)

GHA: windows java 11

2023-11-30T14:24:08.2895423Z [ERROR] Tests run: 56, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 4.204 s <<< FAILURE! -- in org.drools.mvel.integrationtests.ExpirationTest
2023-11-30T14:24:08.2922698Z [ERROR] org.drools.mvel.integrationtests.ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM[KieBase type=STREAM_IDENTITY] -- Time elapsed: 0.062 s <<< FAILURE!
2023-11-30T14:24:08.2924517Z org.junit.ComparisonFailure: expected:<[0]L> but was:<[1]L>

=> ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM may be related to this PR? Sorry, I didn't dig deeper.

Jenkins:

[INFO] --- maven-compiler-plugin:3.11.0:compile (default-compile) @ drools-canonical-model ---
[INFO] Changes detected - recompiling the module! :dependency
[INFO] Compiling 298 source files with javac [debug release 11] to target/classes
An exception has occurred in the compiler (17.0.8). Please file a bug against the Java compiler via the Java bug reporting page (https://bugreport.java.com) after checking the Bug Database (https://bugs.java.com) for duplicates. Include your program, the following diagnostic, and the parameters passed to the Java compiler in your report. Thank you.
java.lang.NullPointerException: Cannot invoke "com.sun.tools.javac.code.Type.getThrownTypes()" because "tree.meth.type" is null
        at jdk.compiler/com.sun.tools.javac.comp.Flow$FlowAnalyzer.visitApply(Flow.java:1439)
        at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1797)
        at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
        at jdk.compiler/com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:444)

=> Probably just Jenkins environment issue. Other PR doesn't raise the error.

[kie-ci3]

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5605 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5605/2/display/redirect

Test results:

• PASSED: 21973
• FAILED: 2

Those are the test failures:

org.drools.mvel.integrationtests.ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM[KieBase type=STREAM_IDENTITY]

expected:<[0]L> but was:<[1]L>

org.drools.mvel.integrationtests.ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM[KieBase type=STREAM_IDENTITY_MODEL_PATTERN]

expected:<[0]L> but was:<[1]L>

[kie-ci3]

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5605 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5605/1/display/redirect

Test results:

• PASSED: 22014
• FAILED: 2

Those are the test failures:

org.drools.mvel.integrationtests.ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM[KieBase type=STREAM_IDENTITY]

expected:<[0]L> but was:<[1]L>

org.drools.mvel.integrationtests.ExpirationTest.testAvoidAlreadyExpiredFactsToForeverRemainInWM[KieBase type=STREAM_IDENTITY_MODEL_PATTERN]

expected:<[0]L> but was:<[1]L>