-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #3782] Properly resolving root dir in all CI environments #3783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly, good catch @fjtirado !
Returns root dir from any child module, checked with mvn directory:highest-basedir
.
My only comment is about the version of the plugin, latest 1.0 seems more stable though 0.1 works also fine.
Co-authored-by: Gonzalo Muñoz <[email protected]>
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3783 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3783/1/display/redirect Test results:
Those are the test failures: org.jbpm.usertask.jpa.quarkus.PostgreSQLQuarkusJPAUserTaskInstancesTest.testFindByIdentityByPotentialGroupsjava.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.PostgreSqlQuarkusTestResourceorg.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest1 expectation failed.Expected status code <201> but was <404>. |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3783 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3783/2/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest1 expectation failed.Expected status code <201> but was <404>. |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3783 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3783/5/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest1 expectation failed.Expected status code <201> but was <404>. |
…pache#3783) * [Fix apache#3782] Properly resolving root dir in all CI environments * Update kogito-build/kogito-build-no-bom-parent/pom.xml Co-authored-by: Gonzalo Muñoz <[email protected]> * Use relative path for resources * Change phase to validate * [Fix apache#3782] Using relative path --------- Co-authored-by: Gonzalo Muñoz <[email protected]> Co-authored-by: gmunozfe <[email protected]>
…pache#3783) * [Fix apache#3782] Properly resolving root dir in all CI environments * Update kogito-build/kogito-build-no-bom-parent/pom.xml Co-authored-by: Gonzalo Muñoz <[email protected]> * Use relative path for resources * Change phase to validate * [Fix apache#3782] Using relative path --------- Co-authored-by: Gonzalo Muñoz <[email protected]> Co-authored-by: gmunozfe <[email protected]>
…pache#3783) (#82) * [Fix apache#3782] Properly resolving root dir in all CI environments * Update kogito-build/kogito-build-no-bom-parent/pom.xml * Use relative path for resources * Change phase to validate * [Fix apache#3782] Using relative path --------- Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Fix #3782
Merge with apache/incubator-kie-kogito-apps#2144