Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3782] Properly resolving root dir in all CI environments #3783

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Nov 18, 2024

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, good catch @fjtirado !
Returns root dir from any child module, checked with mvn directory:highest-basedir.
My only comment is about the version of the plugin, latest 1.0 seems more stable though 0.1 works also fine.

kogito-build/kogito-build-no-bom-parent/pom.xml Outdated Show resolved Hide resolved
@kie-ci3
Copy link
Contributor

kie-ci3 commented Nov 18, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3783 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3783/1/display/redirect

Test results:

  • PASSED: 2951
  • FAILED: 2

Those are the test failures:

org.jbpm.usertask.jpa.quarkus.PostgreSQLQuarkusJPAUserTaskInstancesTest.testFindByIdentityByPotentialGroups java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.PostgreSqlQuarkusTestResource
org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest 1 expectation failed.
Expected status code <201> but was <404>.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Nov 18, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3783 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3783/2/display/redirect

Test results:

  • PASSED: 3486
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest 1 expectation failed.
Expected status code <201> but was <404>.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Nov 19, 2024

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3783 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3783/5/display/redirect

Test results:

  • PASSED: 3480
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest 1 expectation failed.
Expected status code <201> but was <404>.

@fjtirado fjtirado merged commit ab02861 into apache:main Nov 20, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 25, 2024
…pache#3783)

* [Fix apache#3782] Properly resolving root dir in all CI environments

* Update kogito-build/kogito-build-no-bom-parent/pom.xml

Co-authored-by: Gonzalo Muñoz <[email protected]>

* Use relative path for resources

* Change phase to validate

* [Fix apache#3782] Using relative path

---------

Co-authored-by: Gonzalo Muñoz <[email protected]>
Co-authored-by: gmunozfe <[email protected]>
gmunozfe added a commit to gmunozfe/kie-kogito-runtimes that referenced this pull request Nov 26, 2024
…pache#3783)

* [Fix apache#3782] Properly resolving root dir in all CI environments

* Update kogito-build/kogito-build-no-bom-parent/pom.xml

Co-authored-by: Gonzalo Muñoz <[email protected]>

* Use relative path for resources

* Change phase to validate

* [Fix apache#3782] Using relative path

---------

Co-authored-by: Gonzalo Muñoz <[email protected]>
Co-authored-by: gmunozfe <[email protected]>
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Nov 26, 2024
…pache#3783) (#82)

* [Fix apache#3782] Properly resolving root dir in all CI environments

* Update kogito-build/kogito-build-no-bom-parent/pom.xml



* Use relative path for resources

* Change phase to validate

* [Fix apache#3782] Using relative path

---------

Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong value for project.root.dir property
4 participants