Skip to content

Commit

Permalink
Address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
maobaolong committed Nov 16, 2024
1 parent dcac751 commit 0b12740
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -719,8 +719,8 @@ public class ShuffleServerConf extends RssBaseConf {
.booleanType()
.defaultValue(false)
.withDescription("Whether to enable app detail log");
public static final ConfigOption<Boolean> SERVER_TRIGGER_REPORT_WHILE_UNREGISTER_ENABLED =
ConfigOptions.key("rss.server.trigger.report.while.unregister.enabled")
public static final ConfigOption<Boolean> SERVER_HEARTBEAT_REPORT_ON_UNREGISTER_ENABLED =
ConfigOptions.key("rss.server.heartbeatReportOnUnregisterEnabled")
.booleanType()
.defaultValue(false)
.withDescription("Whether to trigger report while unregister");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public void unregisterShuffleByAppId(
try {
if (shuffleServer
.getShuffleServerConf()
.getBoolean(ShuffleServerConf.SERVER_RPC_AUDIT_LOG_ENABLED)) {
.getBoolean(ShuffleServerConf.SERVER_HEARTBEAT_REPORT_ON_UNREGISTER_ENABLED)) {
shuffleServer.sendHeartbeat();
}
shuffleServer.getShuffleTaskManager().removeShuffleDataAsync(appId);
Expand Down

0 comments on commit 0b12740

Please sign in to comment.