Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2259] fix(server) dataLength of ShuffleBufferWithLinkedList not be cleared after toFlushEvent #2260

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

lwllvyb
Copy link
Contributor

@lwllvyb lwllvyb commented Nov 23, 2024

What changes were proposed in this pull request?

The private variable dataLength of ShuffleBufferWithLinkedList will be cleared after toFlushEvent.

Why are the changes needed?

The private variable dataLength of ShuffleBufferWithLinkedList not be cleared after toFlushEvent.

Fix: #2259

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested by UT.

@lwllvyb lwllvyb changed the title fix(server) dataLength of ShuffleBufferWithLinkedList not clear after toFlushEvent [#2259] fix(server) dataLength of ShuffleBufferWithLinkedList not clear after toFlushEvent Nov 23, 2024
Copy link

Test Results

 2 956 files  + 6   2 956 suites  +6   6h 25m 25s ⏱️ + 12m 44s
 1 092 tests ± 0   1 090 ✅ + 2   2 💤 ±0  0 ❌  - 1 
13 685 runs  +12  13 655 ✅ +14  30 💤 ±0  0 ❌  - 1 

Results for commit 27d3e67. ± Comparison against base commit ab1d3ae.

@lwllvyb lwllvyb changed the title [#2259] fix(server) dataLength of ShuffleBufferWithLinkedList not clear after toFlushEvent [#2259] fix(server) dataLength of ShuffleBufferWithLinkedList not be cleared after toFlushEvent Nov 23, 2024
@jerqi
Copy link
Contributor

jerqi commented Nov 25, 2024

What will the bug cause?

Copy link
Member

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwllvyb Good catch, thanks for your contribution!

@jerqi This issue can cause wrong calculated metrics and logs.

@jerqi
Copy link
Contributor

jerqi commented Nov 25, 2024

@lwllvyb Good catch, thanks for your contribution!

@jerqi This issue can cause wrong calculated metrics and logs.

OK. LGTM.

@maobaolong maobaolong merged commit 54611f3 into apache:master Nov 25, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The private variable dataLength of ShuffleBufferWithLinkedList not be cleared after toFlushEvent.
3 participants