-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-10017][Sort] Add the definition of Sort Config #10018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luchunliang
previously approved these changes
Apr 19, 2024
dockerzhang
changed the title
[INLONG-10017][Sort] Definition of Sort Config
[INLONG-10017][Sort] Add the definition of Sort Config
Apr 19, 2024
dockerzhang
previously approved these changes
Apr 19, 2024
fuweng11
reviewed
Apr 19, 2024
inlong-common/src/main/java/org/apache/inlong/common/pojo/sort/dataflow/DataflowConfig.java
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
component/dataproxy
component/agent
component/audit
component/sdk
labels
Apr 20, 2024
fuweng11
previously approved these changes
Apr 20, 2024
fuweng11
approved these changes
Apr 20, 2024
aloyszhang
approved these changes
Apr 21, 2024
luchunliang
approved these changes
Apr 21, 2024
dockerzhang
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
To unify the Sort Config of SortStandalone and SortFlink, we propose a new protocol to describe the configuration hierarchy of Sort.
This issue is about the definition of a set of POJOs.
The precondition of #9867
Modifications
The format definitions are moved to inlong-common dictionary.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation