[INLONG-9883][Manager] Add unit test of HeartbeatController #10019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This UT cannot verify whether the API's functionality meets expectations.Please refer to StreamSourceServiceTest.testGetAndUpdate to verify whether the actual functionality of the API is effective. |
|
The PageResult class use named list field to save list data. So, I modify "record" to "list" in the WebBaseTest class. |
fuweng11
previously approved these changes
Apr 20, 2024
fuweng11
reviewed
Apr 20, 2024
...ager-web/src/test/java/org/apache/inlong/manager/web/controller/HeartbeatControllerTest.java
Outdated
Show resolved
Hide resolved
...ager-web/src/test/java/org/apache/inlong/manager/web/controller/HeartbeatControllerTest.java
Outdated
Show resolved
Hide resolved
fuweng11
approved these changes
Apr 20, 2024
dockerzhang
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Title Example: [INLONG-9883][Manager] Add unit test of HeartbeatController
Fixes [Improve][Manager] Add unit test of HeartbeatController #9883
Motivation
Complete the pr #9887
Modifications
Add HeartbeatController, Modify assert statement condition