Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10041][Sort] Thread unsafety of time format serialization #10042

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

vernedeng
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

The serialization and deserialization of the Timestamp, Time, and Date format of Sort will produce unexcepted results because SimpleDateFormatter is thread-unsafe.

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng requested a review from luchunliang April 22, 2024 08:22
@vernedeng vernedeng self-assigned this Apr 22, 2024
luchunliang
luchunliang previously approved these changes Apr 22, 2024
@dockerzhang dockerzhang merged commit 3abb856 into apache:master Apr 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Sort] Thread unsafety of time format serialization
3 participants