-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-10833][SDK] Transform SQL supports parsing of Mod methods and % expressions #10853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloyszhang
previously approved these changes
Aug 22, 2024
@Zkplo please fix the code format |
@aloyszhang Thank you for the reminder, it has now been revised. |
aloyszhang
previously approved these changes
Aug 22, 2024
yfsn666
reviewed
Aug 25, 2024
.../java/org/apache/inlong/sdk/transform/process/TestTransformArithmeticFunctionsProcessor.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/inlong/sdk/transform/process/TestTransformArithmeticFunctionsProcessor.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/inlong/sdk/transform/process/TestTransformArithmeticFunctionsProcessor.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/inlong/sdk/transform/process/TestTransformArithmeticFunctionsProcessor.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/inlong/sdk/transform/process/TestTransformArithmeticFunctionsProcessor.java
Show resolved
Hide resolved
aloyszhang
approved these changes
Aug 26, 2024
luchunliang
approved these changes
Aug 27, 2024
yfsn666
approved these changes
Aug 27, 2024
vernedeng
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10833
Motivation
Added ModuloFunction and ModuloParser. Also, add the corresponding unit test codes
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation