Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10833][SDK] Transform SQL supports parsing of Mod methods and % expressions #10853

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

Zkplo
Copy link
Contributor

@Zkplo Zkplo commented Aug 22, 2024

Fixes #10833

Motivation

Added ModuloFunction and ModuloParser. Also, add the corresponding unit test codes

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

aloyszhang
aloyszhang previously approved these changes Aug 22, 2024
@aloyszhang
Copy link
Contributor

@Zkplo please fix the code format

@Zkplo
Copy link
Contributor Author

Zkplo commented Aug 22, 2024

@aloyszhang Thank you for the reminder, it has now been revised.

aloyszhang
aloyszhang previously approved these changes Aug 22, 2024
@Zkplo Zkplo requested a review from yfsn666 August 26, 2024 08:51
@aloyszhang aloyszhang merged commit e30e493 into apache:master Aug 27, 2024
8 checks passed
@Zkplo Zkplo deleted the dev2 branch August 27, 2024 04:40
PeterZh6 pushed a commit to PeterZh6/inlong that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL supports parsing of Mod methods and % expressions
5 participants