Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10882][SDK] Transform SQL support ASCII function #10994

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

MOONSakura0614
Copy link
Contributor

Fixes #10882

Motivation

Modifications

Add a function class: AsciiFunction and its unit test.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

aloyszhang
aloyszhang previously approved these changes Sep 3, 2024
luchunliang
luchunliang previously approved these changes Sep 3, 2024
@aloyszhang
Copy link
Contributor

@MOONSakura0614 Pleas fix the conflict

… into INLONG-10882

# Conflicts:
#	inlong-sdk/transform-sdk/src/test/java/org/apache/inlong/sdk/transform/process/TestTransformStringFunctionsProcessor.java
@MOONSakura0614
Copy link
Contributor Author

@MOONSakura0614 Pleas fix the conflict

done

luchunliang
luchunliang previously approved these changes Sep 4, 2024
@MOONSakura0614 MOONSakura0614 dismissed luchunliang’s stale review September 4, 2024 01:43

The merge-base changed after approval.

luchunliang
luchunliang previously approved these changes Sep 4, 2024
@MOONSakura0614 MOONSakura0614 dismissed luchunliang’s stale review September 4, 2024 01:48

The merge-base changed after approval.

luchunliang
luchunliang previously approved these changes Sep 4, 2024
@MOONSakura0614 MOONSakura0614 dismissed luchunliang’s stale review September 4, 2024 10:24

The merge-base changed after approval.

@MOONSakura0614
Copy link
Contributor Author

@luchunliang @vernedeng @aloyszhang Sorry for demanding another review. I resolve the test conflict and re-commit.

@dockerzhang dockerzhang merged commit e33a5e8 into apache:master Sep 12, 2024
8 checks passed
PeterZh6 pushed a commit to PeterZh6/inlong that referenced this pull request Sep 23, 2024
wohainilaodou pushed a commit to wohainilaodou/inlong that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Transform SQL support ASCII function
4 participants