[INLONG-11201][Sort] Enhanced sink metric instrumentation for Flink StarRocks Connector #11206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [Feature][Sort] Enhanced sink metric instrumentation for InLong Sort Flink Connector #11201
Motivation
This PR aims to enhance sink metric instrumentation for the InLong Sort Flink Connector, particularly the StarRocks Connector. The enhancements are designed to improve observability by adding metrics that track serialization, snapshot states, and checkpoint completion.
Modifications
This feature focuses on Sink Metrics only
Serialization Metrics:
numSerializeSuccess
numSerializeError
serializeTimeLag
Snapshot State Metrics:
numSnapshotCreate
numSnapshotError
NotifyComplete Metrics:
numSnapshotComplete
snapshotToCheckpointTimeLag
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
sort-end-to-end-tests-v1.15
The result is shown in the screenshot, with the metrics marked in red
Click To View Image
Preparation:
To enable self-defined metrics, one has to add
inlong.metric.labels
in theinlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.15/src/test/resources/flinkSql
Method 1:
Add
while(true){}
code snippet to the end of any test undersort-end-to-end-test-v1.15
that involvesstarrocks
connnector. For example, inPostgres2StarRocksTest
, simply remove check result code and add a while loop at the end. And then visitlocalhost:8081
, which is Flink Web Dashboard, and find Metrics column.Method 2:
taskmanager
to report metrics using the Slf4jReporter. Add the following toconf/flink-conf.yaml
:Documentation