Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11614][Agent] Fix the signal leakage issue of AbstractSource class #11615

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Dec 19, 2024

Fixes #11614

Motivation

Fix the signal leakage issue of AbstractSource class

Modifications

After the prepareToRead function executes an exception, it is considered that the data source can be terminated

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang merged commit 6816f9f into apache:master Dec 20, 2024
11 checks passed
@justinwwhuang justinwwhuang deleted the b11614 branch December 30, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] The AbstractSource class poses a risk of semaphore leakage
3 participants