OAK-9447: Upgrade Mongo java driver to 5.2 #1789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OAK-9447 * Conflict with trunk resolved * Conflict resolved * conflict resolved * Reordered imports like original classes and fixed oak-run about new mongodb-driver-sync * Reordered imports like original classes * Upgraded com.mongodb and org.bson versions in Import-Package * Restored original formatting * Restored original import ordering * Restored original import ordering --------- Co-authored-by: raffaega <raffaega@CI00298583> Co-authored-by: raffaega <[email protected]> Co-authored-by: Raffaele Gambelli <[email protected]> Co-authored-by: Raffaele Gambelli <[email protected]>
reschke
requested review from
rishabhdaim,
nfsantos and
mreutegg
and removed request for
rishabhdaim and
nfsantos
rishabhdaim
requested changes
Oct 14, 2024
| @@ -508,7 +507,7 @@ private void configureEstimators(IndexingProgressReporter progressReporter) { | |||
| private long getEstimatedDocumentCount() { | |||
| MongoConnection mongoConnection = indexHelper.getService(MongoConnection.class); | |||
| if (mongoConnection != null) { | |||
| return mongoConnection.getDatabase().getCollection("nodes").count(); | |||
| return mongoConnection.getDatabase().getCollection("nodes").countDocuments(); | |||
There was a problem hiding this comment.
Suggested change
| return mongoConnection.getDatabase().getCollection("nodes").countDocuments(); | |
| return mongoConnection.getDatabase().getCollection("nodes").estimatedDocumentCount(); |
countDcuments is very slow. I would use estimatedDocumentCount for faster results.
See https://www.mongodb.com/community/forums/t/countdocuments-is-extremly-slow/207357
| @@ -43,8 +43,8 @@ | |||
| <configuration> | |||
| <instructions> | |||
| <Import-Package> | |||
| com.mongodb*;version="[3.8, 4)";resolution:=optional, | |||
| org.bson*;version="[3.8, 4)";resolution:=optional, | |||
| com.mongodb*;version="[5.0, 5.2)";resolution:=optional, | |||
There was a problem hiding this comment.
Since we are switching to 5.2.0, shouldn't it be
Suggested change
| com.mongodb*;version="[5.0, 5.2)";resolution:=optional, | |
| com.mongodb*;version="[5.2, 6)";resolution:=optional, |
| com.mongodb*;version="[3.8, 4)";resolution:=optional, | ||
| org.bson*;version="[3.8, 4)";resolution:=optional, | ||
| com.mongodb*;version="[5.0, 5.2)";resolution:=optional, | ||
| org.bson*;version="[5.0, 5.2)";resolution:=optional, |
There was a problem hiding this comment.
Yes, definitely, or 5.3) may be better, as sometimes they also introduce breaking changes or deprecated methods in minor versions. Example in 5.1: https://www.mongodb.com/docs/drivers/java/sync/v5.2/whats-new/#what-s-new-in-5.1
And in 4.x it happened quite more frequently: https://www.mongodb.com/docs/drivers/java/sync/v5.2/upgrade/#version-4.8-breaking-changes
| @@ -2345,11 +2339,6 @@ private boolean withClientSession() { | |||
| return connection.getStatus().isClientSessionSupported() && useClientSession; | |||
| } | |||
|
|
|||
| private boolean secondariesWithinAcceptableLag() { | |||
| return getClient().getReplicaSetStatus() == null | |||
| || connection.getStatus().getReplicaSetLagEstimate() < acceptableLagMillis; | |||
There was a problem hiding this comment.
acceptableLagMillis should be marked as deprecated since it won't be used anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.