-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK-11247: Migrated groovy test files to Java #1851
base: trunk
Are you sure you want to change the base?
OAK-11247: Migrated groovy test files to Java #1851
Conversation
a03197d
to
ea0ede3
Compare
Removed gmavenplus plugin from pom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Amoratinos , i just looked at the SecurityProviderRegistrationTest and that one looks good if we conclude that we want to keep the existing module and the way it's running tests... which is probably what we can achieve with limited effort.
an alternative approach would be to rewrite the intention of the tests within the oak modules they belong to, get rid of the mocking and use PaxExam to build ITs that accurately reflect running oak in a OSGi setup like we have it in Adobe AEM. but maybe that's too much of an effort compared to the gain.
I'm fine to take that task with me but I think that's a broader scope of the task. Specially from reviewer's point of view it would need to invest more time and effort to go over the changes. If it's fine for you I'll create a new ticket asking to change that test to use PaxExam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really can't review.
It the Groovy dependency is gone, and integration tests are passing ("-PintegrationTesting"), this should be good.
@AngelaFabregues - paxExam is abandoned; we should not use it in "new" code (see https://mvnrepository.com/artifact/org.ops4j.pax.exam/pax-exam) |
Migrated Groovy test files in oak-pojosr package to Java.
Asserts were changed to use junit assert methods imported statically.