Removes the deprecated packages Log4j configuration attribute
#6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking into this. |
vlsi
force-pushed
the
fix/5937_packages_attribute
branch
from
50d7f1d to
b968bab
Compare
…er The use of package scanning to locate plugins is deprecated ... The Log4j Core `packages` configuration attribute is deprecated because: * It triggers the scanning of the mentioned packages and slows down the startup process. * It was replaced in version 2.0 by a faster mechanism that relies on a `Log4jPlugins.dat` metadata file. See [Log4j Plugins](https://logging.apache.org/log4j/2.x/manual/plugins.html) for more details. This PR removes the `packages` attribute from the standard configuration file and configures the build script of `jmeter-core` to use the `PluginProcessor` contained in `log4j-core`. See apache#5937.
vlsi
force-pushed
the
fix/5937_packages_attribute
branch
from
b968bab to
cbdfd1b
Compare
vlsi
reviewed
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
packagesattribute from the standard configuration file and configures the build script ofjmeter-coreto use thePluginProcessorcontained inlog4j-core.See Log4j Plugins for more details.
See #5937.
Motivation and Context
The Log4j Core
packagesconfiguration attribute is deprecated because:Log4jPlugins.datmetadata file.How Has This Been Tested?
After the changes
bin/jmeterdoes not print any Log4j warnings on the console.Types of changes
Checklist: