Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2975, KNOX-2976 - Expired tokens must not be enabled/disabled in batches #812

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

smolnar82
Copy link
Contributor

What changes were proposed in this pull request?

The following Token Management UI improvements were implemented here:

  • Enable/Disable Selected Tokens buttons are hidden if the selection contains at least 1 expired token
  • Tips are shown on why certain batch operation buttons are hidden

How was this patch tested?

Manually tested on my local Token Management UI:
Screenshot 2023-10-30 at 10 15 16
Screenshot 2023-10-30 at 10 15 31
Screenshot 2023-10-30 at 10 15 48
Screenshot 2023-10-30 at 10 16 17
Screenshot 2023-10-30 at 10 16 32

… batches

Additionally, useful tips are shown on why batch operation actions are hidden (e.g. KnoxSSO Cookies must not be revoked).
@smolnar82 smolnar82 self-assigned this Oct 30, 2023
@smolnar82 smolnar82 added knoxtoken javascript Pull requests that update Javascript code angular labels Oct 30, 2023
@smolnar82 smolnar82 merged commit 7a5189a into apache:master Oct 30, 2023
2 checks passed
@smolnar82 smolnar82 deleted the KNOX-2976 branch October 30, 2023 10:26
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
… be enabled/disabled in batches (apache#812)

Additionally, useful tips are shown on why batch operation actions are hidden (e.g. KnoxSSO Cookies must not be revoked).

Change-Id: I1c5a3d3f3390c43755978f6faf9457541ab538a6
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
* changes:
  CDPD-63091, KNOX-2980: Applying word wrapping in various columns that can have 'long' content. (apache#816)
  CDPD-62588, KNOX-2979: Removed redundant 'refresh' query parameter from the application logout link after originalUrl (apache#815)
  CDPD-62869, CDPD-62870, KNOX-2975, KNOX-2976: Expired tokens must not be enabled/disabled in batches (apache#812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular javascript Pull requests that update Javascript code knoxtoken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants