KNOX-2958 - Fixed API samples for certain services #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, a general improvement is implemented that adds the missing slash at the beginning of the path element if it was missing from the service definition sample.
zeroflag
approved these changes
Oct 31, 2023
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…e#814) Additionally, a general improvement is implemented that adds the missing slash at the beginning of the path element if it was missing from the service definition sample. Change-Id: I6803c7b72c38bc935bcf85b9e871b7e1c6604b18
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
* changes: CDPD-61199: Updated public sample API document links to match versions in CDP CDPD-61196, KNOX-2958 - Fixed API samples for certain services (apache#814)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Testing uncovered some API samples in the existing service definition files that needed to be fixed.
Additionally, a general improvement is implemented that adds the missing slash at the beginning of the path element if it was missing from the service definition sample.
How was this patch tested?
Added unit tests and confirmed that API samples are actually changed on the UI:
To see the new-style API service dialog it's essential that you set the following property in
gateway-site.xml: