Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 #852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 27, 2024

Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 27, 2024
@lmccay
Copy link
Contributor

lmccay commented Oct 20, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.derby-derby-10.17.1.0 branch from 51cf2b4 to 941ccba Compare October 20, 2024 18:03
@lmccay
Copy link
Contributor

lmccay commented Oct 20, 2024

This dependency bump breaks tests due to missing EmbeddedDriver class. Note that this resolves a critical CVE on derby for LDAP based authentication bypass. We don't use LDAP to authenticate to derby here. We should address this anyway though since there is an incompatibility in newer releases.

Error: testJDBCBuilderUsingConnectionString(org.apache.knox.gateway.shell.table.KnoxShellTableTest) Time elapsed: 0.02 s <<< ERROR!
org.apache.knox.gateway.shell.jdbc.derby.DerbyDatabaseException: Unable to load the JDBC driver org.apache.derby.jdbc.EmbeddedDriver. Check your CLASSPATH.
at org.apache.knox.gateway.shell.table.KnoxShellTableTest.prepareDerbyDatabase(KnoxShellTableTest.java:513)
at org.apache.knox.gateway.shell.table.KnoxShellTableTest.testJDBCBuilderUsingConnectionString(KnoxShellTableTest.java:498)
Caused by: java.lang.ClassNotFoundException: org.apache.derby.jdbc.EmbeddedDriver
at org.apache.knox.gateway.shell.table.KnoxShellTableTest.prepareDerbyDatabase(KnoxShellTableTest.java:513)
at org.apache.knox.gateway.shell.table.KnoxShellTableTest.testJDBCBuilderUsingConnectionString(KnoxShellTableTest.java:498)

@smolnar82
Copy link
Contributor

@dependabot rebase

Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.

---
updated-dependencies:
- dependency-name: org.apache.derby:derby
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.derby-derby-10.17.1.0 branch from 941ccba to daee149 Compare November 25, 2024 06:09
@smolnar82
Copy link
Contributor

Hm...Derby above 10.15.x needs another library (the modularized their project):
image

@smolnar82
Copy link
Contributor

smolnar82 commented Nov 25, 2024

On the other hand, it seems Knox cannot be upgraded above 10.14.2.0 due to its Java 8 dependency:
image
As @lmccay pointed out, using 10.14.2.0 is not an issue currently, because we don't use LDAP at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants