Skip repeated checks on convert function in TColumnGenerator #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6786 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42439 42439
Branches 5793 5793
======================================
Misses 42439 42439 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Oct 31, 2024
| val value = if (isConvertFuncDefined) { | ||
| convertFunc(row, ordinal) | ||
| } else { | ||
| getColumnAs[T](row, ordinal) |
There was a problem hiding this comment.
let's use a simple way
if (convertFunc == null) {
...
} else {
...
}
There was a problem hiding this comment.
I would still prefer to use an extracted boolean value for this. I assume that accessing a boolean costs less step and byte code steps for comparing convertFunc to null, especially since it's repeatedly used and checked once for each row.
yaooqinn
approved these changes
Nov 12, 2024
bowenliang123
added a commit
that referenced
this pull request
Nov 12, 2024
…erator # 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 - `TColumnGenerator` is used for generating column-based data. This PR skips repeated checks on checking nullability of the convert function in generating single column. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6786 from bowenliang123/skip-converfunc-check. Closes #6786 f76f686 [Bowen Liang] nit 930dfef [Bowen Liang] fix 9712274 [Bowen Liang] comment 9db16ef [Bowen Liang] nit 977d215 [Bowen Liang] skip repeated checking on convert function Authored-by: Bowen Liang <[email protected]> Signed-off-by: Bowen Liang <[email protected]> (cherry picked from commit c8b8922) Signed-off-by: Bowen Liang <[email protected]>
|
Thanks, merged to master (1.11.0) and branch-1.10 (1.10.1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
TColumnGeneratoris used for generating column-based data. This PR skips repeated checks on checking nullability of the convert function in generating single column.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.