Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the compatibility of queryTimeout in more version clients #6787

Closed
wants to merge 2 commits into from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Oct 29, 2024

🔍 Description

Issue References 🔗

This pull request fixes #2112

Describe Your Solution 🔧

Similar to #2113, the query-timeout-thread should verify the Thrift protocol version. For protocol versions <= HIVE_CLI_SERVICE_PROTOCOL_V8, it should convert TIMEDOUT_STATE to CANCELED.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

Copy link
Contributor

@cxzl25 cxzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since 2112 was released very early, it is recommended to use the new Kyuubi ID instead of FOLLOWUP.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d3520dd) to head (9fbe1ac).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rg/apache/kyuubi/operation/AbstractOperation.scala 0.00% 5 Missing ⚠️
...org/apache/kyuubi/operation/ExecuteStatement.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6787   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         687     687           
  Lines       42439   42441    +2     
  Branches     5793    5793           
======================================
- Misses      42439   42441    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsm1 lsm1 changed the title [KYUUBI #2112][FOLLOWUP] Improve the compatibility of queryTimeout in more version clients [KYUUBI #6787] Improve the compatibility of queryTimeout in more version clients Oct 30, 2024
@lsm1
Copy link
Contributor Author

lsm1 commented Oct 30, 2024

LGTM. Since 2112 was released very early, it is recommended to use the new Kyuubi ID instead of FOLLOWUP.

done

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

And how about extracting a method isHive21OrLower for getProtocolVersion.getValue <=TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V8.getValue, which is duplicated with org.apache.kyuubi.operation.ExecuteStatement Line 127 ?

@bowenliang123 bowenliang123 changed the title [KYUUBI #6787] Improve the compatibility of queryTimeout in more version clients Improve the compatibility of queryTimeout in more version clients Nov 1, 2024
@lsm1 lsm1 force-pushed the branch-timer-checker-set-cancel branch from 5f69295 to 9fbe1ac Compare November 1, 2024 05:48
@lsm1 lsm1 self-assigned this Nov 4, 2024
@lsm1 lsm1 closed this in c9d9433 Nov 4, 2024
@lsm1
Copy link
Contributor Author

lsm1 commented Nov 4, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Improve the compatibility of queryTimeout in more version clients
5 participants