Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][PS-DataSource] DataSource supports merging into a separate service startup #4934

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

DataSource supports merging into a separate service startup
add params

 val LINKIS_DATASOURCE_SERVICE_LIST: Array[String] =
    CommonVars(
      "linkis.gateway.conf.linkisdatasource.list",
      "data-source-manager,metadataquery,datasource,metadataQuery,metadatamanager"
    ).getValue
      .split(",")

Related issues/PRs

Related issues: #4933

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peacewong peacewong merged commit 95f229a into apache:master Oct 16, 2023
12 checks passed
@peacewong peacewong deleted the master-spring-service branch October 23, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants