Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SqlConnection.java #4942

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Update SqlConnection.java #4942

merged 1 commit into from
Oct 26, 2023

Conversation

chengrui1
Copy link
Contributor

What is the purpose of the change

When use service_name to connect to oracle, should pass in serviceName instead of database

Related issues/PRs

Brief change log

Use serviceName instead of database

Checklist

When you use service_name to connect to oracle, should pass in serviceName instead of database
Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong
Copy link
Contributor

Can you add me on wechat? My account is peaceAyton @chengrui1

@peacewong peacewong merged commit e795525 into apache:master Oct 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants