-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a containerized mode to the ECM service #5201
Add a containerized mode to the ECM service #5201
Conversation
…pecific IPs and ports for communication with the outside world to particular engines in this mode. For instance, a Spark engine requires at least two ports: spark.driver.port and spark.driver.blockManager.port.
SPARK_DRIVER_BLOCK_MANAGER_PORT.key, | ||
SPARK_DRIVER_BLOCK_MANAGER_PORT.getValue(options) | ||
) | ||
sparkConfig.setConf(conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is necessary because the sparkConf object does not have a directly available method to set parameters such as spark.driver.port. Instead, these parameters need to be assigned values through sparkConf.setConf
…nce within the configmap-init-sql.yaml file.
Why did my integration test fail when tested with linkis-cli? How can I check the failure logs? I have executed the integration test in my local environment and it passed. The specific execution command is as follows:
|
|
||
kubectl exec -it -n linkis ${POD_NAME} -- bash -c " \ | ||
sh /opt/linkis/bin/linkis-cli -engineType python-python2 -codeType python -code 'print(\"hello\")' " | ||
sh /opt/linkis/bin/linkis-cli --async true -engineType shell-1 -codeType shell -code \"pwd\" "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asynchronous cannot be used and the task needs to be successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rolled back this part of the code.
…_history within the configmap-init-sql.yaml file.
7713798
to
e4b7ee6
Compare
…ice_instance for ddl file.
9f1e7c2
to
29005f2
Compare
# Conflicts: # linkis-engineconn-plugins/spark/src/main/scala/org/apache/linkis/engineplugin/spark/config/SparkConfiguration.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Add a containerized mode to the ECM service, which allows assigning specific IPs and ports for communication with the outside world to particular engines in this mode. For instance, a Spark engine requires at least two ports: spark.driver.port and spark.driver.blockManager.port.
Related issues/PRs
Related issues: #5199
Checklist