Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the functionality of s3filesystem #5208

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

sjgllgh
Copy link
Contributor

@sjgllgh sjgllgh commented Dec 4, 2024

What is the purpose of the change

  1. Enhance the functionality of s3filesystem to support multipart uploads.
  2. Support the use of s3 storage for BML materials and workspaces.

Related issues/PRs

Related issues: #5207

How to use

  1. base configuration: feat : linkis-storage support s3 filesystem support write/read launch log and resultSet in s3(#4185) #4435
  2. workspace:
    • Set the wds.linkis.filesystem.root.path property in the conf/linkis.properties file. For example: wds.linkis.filesystem.root.path=s3:///workspace.
  3. bml:
    • Configure the linkis.bml.filesystem.type and linkis.bml.prefix properties in the conf/linkis.properties file.
    • Example
      -- linkis.bml.filesystem.type=s3
      -- linkis.bml.prefix =/bml
  4. linkis.bml.filesystem.type Default Value:
    • The default value for linkis.bml.filesystem.type is determined by the wds.linkis.bml.is.hdfs property. If wds.linkis.bml.is.hdfs is true, the default is hdfs; otherwise, the default is file.
  5. linkis.bml.prefix Default Value:
    • The default value for linkis.bml.prefix is determined based on the wds.linkis.bml.is.hdfs property. If wds.linkis.bml.is.hdfs is true, the default prefix is retrieved from the wds.linkis.bml.hdfs.prefix property; otherwise, the default prefix is retrieved from the wds.linkis.bml.local.prefix property.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

…oads.

2. Support the use of s3 storage for BML materials and workspaces.
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 6bc388f into apache:master Dec 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants