Improve plugin descriptor warnings #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
reviewed
Aug 13, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/ResolverUtil.java
Outdated
Show resolved
Hide resolved
|
@vy, I added some test cases to check for the presence of an appropriate warning message. |
vy
approved these changes
Aug 13, 2024
...-test/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerTest.java
Show resolved
Hide resolved
...-test/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerTest.java
Show resolved
Hide resolved
This improves status logger warnings about: * missing `Log4j2Plugin.dat` plugin descriptors, * usage of package scanning. The warnings are reworded in a way that they are more useful to end-users. If package scanning is enabled, linkage errors (almost exclusively due to optional dependencies) are logged at a `DEBUG` level instead of `WARN`. The `PluginManager` tests are revamped to: - Look for a status logger warning if a deprecated plugin scanning feature is used. - Look for a status logger warning if no plugin descriptor is available. This addresses @vlsi suggestions from apache/jmeter#5937 (comment) and fixes #2835. Co-authored-by: Volkan Yazıcı <[email protected]>
ppkarwasz
force-pushed
the
fix/2.x/package-scanning
branch
from
d2bdd02 to
715c97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves status logger warnings about:
Log4j2Plugin.datplugin descriptors,The warnings are reworded in a way that they are more useful to end-users. If package scanning is enabled, linkage errors (almost exclusively due to optional dependencies) are logged at a
DEBUGlevel instead ofWARN.This addresses @vlsi suggestions from apache/jmeter#5937 (comment) and fixes #2835.