-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop net6.0 target and use net6.0 to run netstandard2.1 tests, #1020 #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADO build failed; will investigate. Marking as draft for now. |
Build succeeds on ADO now except for the known #1034 issue. |
paulirwin
added
the
notes:breaking-change
Has changes that will break backward compatibility
label
Nov 19, 2024
1 task
NightOwl888
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
There are a few changes requested, mostly about keeping the documentation changes updated for 4.8.0-beta00017
. See the comments inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop net6.0 target and use net6.0 to run netstandard2.1 tests
Fixes #1020
Description
This drops the out-of-support net6.0 target from the project.
Additionally, it drops the net5.0 target from the tests, which was previously used to test netstandard2.1. With the net6.0 target dropped, we now use net6.0 to test netstandard2.1. This will help alleviate issues running .NET 5 tests on macOS Arm64 as well.
The github workflows were generated using the PowerShell script.