Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop net6.0 target and use net6.0 to run netstandard2.1 tests, #1020 #1039

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Drop net6.0 target and use net6.0 to run netstandard2.1 tests

Fixes #1020

Description

This drops the out-of-support net6.0 target from the project.

Additionally, it drops the net5.0 target from the tests, which was previously used to test netstandard2.1. With the net6.0 target dropped, we now use net6.0 to test netstandard2.1. This will help alleviate issues running .NET 5 tests on macOS Arm64 as well.

The github workflows were generated using the PowerShell script.

@paulirwin
Copy link
Contributor Author

ADO build failed; will investigate. Marking as draft for now.

@paulirwin paulirwin marked this pull request as draft November 19, 2024 22:15
@paulirwin
Copy link
Contributor Author

Build succeeds on ADO now except for the known #1034 issue.

@paulirwin paulirwin marked this pull request as ready for review November 19, 2024 23:01
@paulirwin paulirwin added the notes:breaking-change Has changes that will break backward compatibility label Nov 19, 2024
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

There are a few changes requested, mostly about keeping the documentation changes updated for 4.8.0-beta00017. See the comments inline.

.github/workflows/Generate-TestWorkflows.ps1 Outdated Show resolved Hide resolved
.github/workflows/Generate-TestWorkflows.ps1 Outdated Show resolved Hide resolved
Directory.Build.targets Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TestTargetFramework.props Show resolved Hide resolved
src/dotnet/tools/lucene-cli/docs/index.md Outdated Show resolved Hide resolved
websites/apidocs/apiSpec/core/Lucene_Net_Codecs.md Outdated Show resolved Hide resolved
websites/site/quick-start/tutorial.md Outdated Show resolved Hide resolved
@paulirwin paulirwin merged commit 63f6d5e into apache:master Nov 21, 2024
199 checks passed
@paulirwin paulirwin deleted the issue/1020 branch November 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:breaking-change Has changes that will break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop .NET 6 target
2 participants