Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Review T-Z Tests, #259 #897

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Test review for the T-Z unit test project.

Associated #259 (doesn't fully fix)

Description

  • This addresses some formatting disparities between the Java and C# tests to help make them more line-to-line matching.
  • Comments added in places where our tests differ from upstream.
  • RandomizedTesting.Generators extension method import moved behind a #if !NET6_0_OR_GREATER check, as the namespace was being ignored on .NET 6+ in a few files since .NET 6 added a Random.NextInt64 method. This will help prevent other contributors from thinking this namespace is not needed.
  • A unit test assertion bug on arm64 with division by zero is fixed.
  • The build file has been chmod'ed +x for ease of use
  • Rider IDE files added

Sorry, something went wrong.

- This addresses some formatting disparities between the Java and C#
  tests to help make them more line-to-line matching.
- Comments added in places where our tests differ from upstream.
- RandomizedTesting.Generators extension method import moved behind a
  `#if !NET6_0_OR_GREATER` check, as the namespace was being ignored on
  .NET 6+ in a few files since .NET 6 added a Random.NextInt64 method.
  This will help prevent other contributors from thinking this namespace
  is not needed.
- A unit test assertion bug on arm64 with division by zero is fixed.
- The `build` file has been chmod'ed +x for ease of use
- Rider IDE files added
@paulirwin paulirwin requested a review from NightOwl888 January 18, 2024 18:00
src/Lucene.Net.Tests/Util/BaseSortTestCase.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Util/BaseSortTestCase.cs Show resolved Hide resolved
src/Lucene.Net.Tests/Util/Fst/Test2BFST.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Util/Packed/TestEliasFanoDocIdSet.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Util/TestBroadWord.cs Show resolved Hide resolved
src/Lucene.Net.Tests/Util/Test2BPagedBytes.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Util/TestMergedIterator.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Util/TestSetOnce.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Util/TestBytesRefHash.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good to merge.

@paulirwin paulirwin merged commit 3729f4c into apache:master Jan 22, 2024
197 checks passed
@paulirwin paulirwin deleted the test-review-t-z branch January 22, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants