[MNG-7804] IT for plugin execution order #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
MNG-7804-plugin-execution-order
branch
from
e683cfb to
94ed79b
Compare
ctubbsii
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Good test coverage. Seems like a nice feature addition. Still some outstanding questions, though:
- Does this require the POM/4.2.0 model? Which versions of Maven can use that POM version?
- How does this work with priorities defined in a parent POM or profile?
- What is the numerical type of the priority? Is it an integer, decimal, long, non-negative, strictly positive?
- What if two executions have the same priority? Is that an error, or is it arbitrarily ordered?
gnodet
force-pushed
the
MNG-7804-plugin-execution-order
branch
2 times, most recently
from
3259eea to
9dbe11d
Compare
gnodet
force-pushed
the
MNG-7804-plugin-execution-order
branch
from
9dbe11d to
9d878c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MNG-7804
Main PR: apache/maven#1147